fix: cursor stays where it's supposed to be #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the query is
abcdef
, and move the cursor in the middle ofinput
element and typeZ
, then it will becomeabcZdef
. Here the cursor is supposed to be right afterZ
, but it was wrongly moved to the end of the query.The problem comes from the order of
When
setHighlightedIndex()
is called, theinput.value
is alreadyabcZdef
, butstore.getState().query
is stillabcdef
because the query hasn't been updated to the store yet.So
input.value
becomesabcdef
. Shortly after because ofsetQuery
,input.value
becomesabcZdef
again.In this PR, the order is been reversed, which now correctly sets the query first, and then proceed with the rest. It doesn't move cursor anymore.