feat(js): introduce classNames API
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the `classNames` API to `autocomplete-js` to append class names to each DOM element that Autocomplete creates. The name `classNames` was used to align with the [`className`](https://developer.mozilla.org/en-US/docs/Web/API/Element/className) Web API. This API is useful to map classnames from your website or CSS integration (e.g., Tailwind) to Autocomplete directly.
Haroenv
reviewed
Sep 10, 2020
Shipow
approved these changes
Sep 11, 2020
|
Sorry for being late for the party, but what do you think about accepting |
|
@eunjae-lee If this is what you're referring to, |
|
Oh you're right. I had a brain failure and thought that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
classNamesAPI toautocomplete-jsto append class names to each DOM element that Autocomplete creates. The nameclassNameswas used to align with theclassNameWeb API.This API is useful to map classnames from your website or CSS integration (e.g., Tailwind) to Autocomplete directly.