fix(standalone): use aria label from input

[kontrollanten]

Summary

Use aria-label property from given input element on the new input element.

Result

When using standalone version (with places.js for instance) the aria-label on the target input element will be forwarded to the input element created by autocomplete.js.

[coveralls]

Coverage remained the same at 88.947% when pulling 99b905e on kontrollanten:fix-aria_label into 84b1714 on algolia:master.

[Haroenv]

This looks correct, but I will not have time to review this request until after the holidays. Could you describe which behaviour you are trying to fix? I thought there were already labels?

[kontrollanten]

I'm using places.js and I have this element

<input aria-label="This is my label" id="autocomplete" />

When I call places({ container: document.getElementById('autocomplete') }) the aria-label disappears. What I could see this problem was only in the standalone version. In the autocomplete version it'll be dressed with aria-label here https://github.com/algolia/autocomplete.js/blob/master/src/autocomplete/typeahead.js#L581

[kontrollanten]

@Haroenv A friendly reminder.

[JonathanMontane]

Thanks for the PR, and good catch!

Autocomplete.js has an ariaLabel option exposed (although it seems that it's not correctly forwarded, as you noticed). link

It would probably be better if your fix uses the options.ariaLabel and uses the input's aria-label attribute as a fallback.

Something like that:

  ...
  ariaLabel: options.ariaLabel || input.getAttribute('aria-label')

This would probably have a less surprising behaviour when calling autcomplete('#search-box', { ariaLabel: 'my-label', ... })

[JonathanMontane]

LGTM 👍

[kontrollanten]

Can we have a release for this soon? :)

[Haroenv]

I released 0.36.0 earlier today