fix(algolia): import version from file

algolia · Sep 9, 2020 · d880d8a · d880d8a
1 parent e276c5e
commit d880d8a
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 19 deletions.
diff --git a/packages/autocomplete-preset-algolia/src/results.ts b/packages/autocomplete-preset-algolia/src/results.ts
@@ -1,6 +1,5 @@
-import { version } from '../package.json';
-
 import { flatten } from './utils';
+import { version } from './version';
 
 type SearchClient = any;
 export type Client = any;

diff --git a/packages/autocomplete-preset-algolia/src/version.ts b/packages/autocomplete-preset-algolia/src/version.ts
@@ -0,0 +1 @@
+export const version = '1.0.0-alpha.28';
diff --git a/ship.config.js b/ship.config.js
@@ -1,5 +1,6 @@
 /* eslint-disable import/no-commonjs */
 
+const { execSync } = require('child_process');
 const fs = require('fs');
 const path = require('path');
 
@@ -19,18 +20,6 @@ module.exports = {
     return `yarn publish --access public --tag ${tag}`;
   },
   versionUpdated({ exec, dir, version }) {
-    const updatePackageDependencies = (...changes) => {
-      for (const change of changes) {
-        const { package, dependencies } = change;
-
-        exec(
-          `yarn workspace ${package} add ${dependencies
-            .map((dep) => `"${dep}"`)
-            .join(' ')}`
-        );
-      }
-    };
-
     // Ship.js reads JSON and writes with `fs.writeFileSync(JSON.stringify(json, null, 2))`
     // which causes a lint error in the `lerna.json` file.
     exec('yarn eslint lerna.json --fix');
@@ -42,11 +31,19 @@ module.exports = {
         `@algolia/autocomplete-preset-algolia@^${version}`,
       ],
     });
-
-    fs.writeFileSync(
-      path.resolve(dir, 'packages', 'autocomplete-core', 'src', 'version.ts'),
-      `export const version = '${version}';\n`
-    );
+    updatePackagesVersion({
+      version,
+      files: [
+        path.resolve(dir, 'packages', 'autocomplete-core', 'src', 'version.ts'),
+        path.resolve(
+          dir,
+          'packages',
+          'autocomplete-preset-algolia',
+          'src',
+          'version.ts'
+        ),
+      ],
+    });
   },
   // Skip preparation if it contains only `chore` commits
   shouldPrepare: ({ releaseType, commitNumbersPerType }) => {
@@ -59,3 +56,21 @@ module.exports = {
     return true;
   },
 };
+
+function updatePackageDependencies(...changes) {
+  for (const change of changes) {
+    const { package, dependencies } = change;
+
+    execSync(
+      `yarn workspace ${package} add ${dependencies
+        .map((dep) => `"${dep}"`)
+        .join(' ')}`
+    );
+  }
+}
+
+function updatePackagesVersion({ version, files }) {
+  for (const file of files) {
+    fs.writeFileSync(file, `export const version = '${version}';\n`);
+  }
+}