feat(js): add non-input container invariant

algolia · Dec 7, 2020 · 2e3a8ed · 2e3a8ed
1 parent 0e28f55
commit 2e3a8ed
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/autocomplete-core/src/checkOptions.ts b/packages/autocomplete-core/src/checkOptions.ts
@@ -3,10 +3,10 @@ import { warn } from '@algolia/autocomplete-shared';
 import { AutocompleteOptions, BaseItem } from './types';
 
 export function checkOptions<TItem extends BaseItem>(
-  option: AutocompleteOptions<TItem>
+  options: AutocompleteOptions<TItem>
 ) {
   warn(
-    !option.debug,
+    !options.debug,
     'The `debug` option is meant for development debugging and should not be used in production.'
   );
 }
diff --git a/packages/autocomplete-js/src/autocomplete.ts b/packages/autocomplete-js/src/autocomplete.ts
@@ -1,5 +1,5 @@
 import { BaseItem, createAutocomplete } from '@algolia/autocomplete-core';
-import { createRef } from '@algolia/autocomplete-shared';
+import { createRef, invariant } from '@algolia/autocomplete-shared';
 
 import { createAutocompleteDom } from './createAutocompleteDom';
 import { createEffectWrapper } from './createEffectWrapper';
@@ -204,6 +204,10 @@ export function autocomplete<TItem extends BaseItem>({
 
   runEffect(() => {
     const containerElement = getHTMLElement(container);
+    invariant(
+      containerElement.tagName !== 'INPUT',
+      'The `container` option does not support `input` elements. You need to change the container to a `div`.'
+    );
     containerElement.appendChild(root);
 
     return () => {