Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glow effects do not work in Hyper 2 #3

Open
jcklpe opened this issue Jul 20, 2018 · 3 comments
Open

Glow effects do not work in Hyper 2 #3

jcklpe opened this issue Jul 20, 2018 · 3 comments

Comments

@jcklpe
Copy link

jcklpe commented Jul 20, 2018

This is possibly due to a shift from Hyper 1's DOM based use of hterm to the canvas based xterm.js which would make css injection into the term window harder/impossible (I don't know anything about how canvas works :/ sorry! just a designer learning to code who got a bug up his ass trying to figure out what was wrong)

@alfg
Copy link
Owner

alfg commented Jul 21, 2018

Ah, that would make sense. I haven't been keeping up with the Hyper updates.

I see you filed an issue on vercel/hyper#3137. I'll be happy to apply a fix if there's a workaround. Or feel free to submit a PR if you find one! :)

@jcklpe
Copy link
Author

jcklpe commented Jul 21, 2018

Sure thing, thanks!

@austriker27
Copy link

Would love to see this updated so we can get the glow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants