diff --git a/.node-version b/.node-version index d5a159609d095..2dbbe00e679a2 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -20.10.0 +20.11.1 diff --git a/.nvmrc b/.nvmrc index d5a159609d095..2dbbe00e679a2 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20.10.0 +20.11.1 diff --git a/WORKSPACE.bazel b/WORKSPACE.bazel index 92192ceab8714..35c8ec6bd0154 100644 --- a/WORKSPACE.bazel +++ b/WORKSPACE.bazel @@ -22,13 +22,13 @@ load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install # Setup the Node.js toolchain for the architectures we want to support node_repositories( node_repositories = { - "20.10.0-darwin_amd64": ("node-v20.10.0-darwin-x64.tar.gz", "node-v20.10.0-darwin-x64", "5ff5e8abd3eea6e5f507eb6677554f5b2188eedef654096aa4168a9941e91a32"), - "20.10.0-darwin_arm64": ("node-v20.10.0-darwin-arm64.tar.gz", "node-v20.10.0-darwin-arm64", "68b93099451d77aac116cf8fce179cabcf53fec079508dc6b39d3a086fb461a8"), - "20.10.0-linux_arm64": ("node-v20.10.0-linux-arm64.tar.xz", "node-v20.10.0-linux-arm64", "a5c22683890d5d244f3afd488ef44e573b5b8287f8911b9a1b061ed3f20a5e6d"), - "20.10.0-linux_amd64": ("node-v20.10.0-linux-x64.tar.xz", "node-v20.10.0-linux-x64", "9c0fbc8cc7be9a6543af4b9afb05759c538c0f81015c388d63277b0158507697"), - "20.10.0-windows_amd64": ("node-v20.10.0-win-x64.zip", "node-v20.10.0-win-x64", "e5b861814a97e28ae7ac06a34e88fd5e0565b447d270c26e20b5ef60bf0aaaf9"), + "20.11.1-darwin_amd64": ("node-v20.11.1-darwin-x64.tar.gz", "node-v20.11.1-darwin-x64", "c52e7fb0709dbe63a4cbe08ac8af3479188692937a7bd8e776e0eedfa33bb848"), + "20.11.1-darwin_arm64": ("node-v20.11.1-darwin-arm64.tar.gz", "node-v20.11.1-darwin-arm64", "e0065c61f340e85106a99c4b54746c5cee09d59b08c5712f67f99e92aa44995d"), + "20.11.1-linux_arm64": ("node-v20.11.1-linux-arm64.tar.xz", "node-v20.11.1-linux-arm64", "36bac185164aa11940715425da1db2ec46e3354325bda9ee0b98b4a607aa0d8b"), + "20.11.1-linux_amd64": ("node-v20.11.1-linux-x64.tar.xz", "node-v20.11.1-linux-x64", "e2c39cb70b9ff79575a02747dd1e89917817cce05da21bef6b94eb9e92442024"), + "20.11.1-windows_amd64": ("node-v20.11.1-win-x64.zip", "node-v20.11.1-win-x64", "bc032628d77d206ffa7f133518a6225a9c5d6d9210ead30d67e294ff37044bda"), }, - node_version = "20.10.0", + node_version = "20.11.1", node_urls = [ "https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/dist/v{version}/{filename}", ], diff --git a/docs/developer/advanced/upgrading-nodejs.asciidoc b/docs/developer/advanced/upgrading-nodejs.asciidoc index 9c4d3d0d98c18..dea7c55704299 100644 --- a/docs/developer/advanced/upgrading-nodejs.asciidoc +++ b/docs/developer/advanced/upgrading-nodejs.asciidoc @@ -19,7 +19,7 @@ These files must be updated when upgrading Node.js: - {kib-repo}blob/{branch}/WORKSPACE.bazel[`WORKSPACE.bazel`] - The version is specified in the `node_version` property. Besides this property, the list of files under `node_repositories` must be updated along with their respective SHA256 hashes. These can be found in the `SHASUMS256.txt` file inside the public `kibana-custom-node-artifacts` GCP bucket. - Example for Node.js v18.18.2: https://storage.googleapis.com/kibana-custom-node-artifacts/node-glibc-217/dist/v18.18.2/SHASUMS256.txt[kibana-custom-node-artifacts/node-glibc-217/dist/v18.18.2/SHASUMS256.txt] + Example for Node.js v20.11.1: https://storage.googleapis.com/kibana-custom-node-artifacts/node-glibc-217/dist/v20.11.1/SHASUMS256.txt[kibana-custom-node-artifacts/node-glibc-217/dist/v20.11.1/SHASUMS256.txt] See PR {kib-repo}pull/128123[#128123] for an example of how the Node.js version has been upgraded previously. @@ -43,7 +43,7 @@ The only difference between the offical Node.js build and our custom build, is t ==== How to start a new build To generate a new custom Node.js build, https://buildkite.com/elastic/kibana-custom-node-dot-js-builds#new[start a new build] on our dedicated Buildkite pipeline (requires Elastic employee permissions). -Give it a clear name (e.g. `Node 18.18.2`) and remember so set the custom `OVERRIDE_TARGET_VERSION` environment variable to the desired Node.js version - e.g. `OVERRIDE_TARGET_VERSION=18.18.2`. +Give it a clear name (e.g. `Node 20.11.1`) and remember so set the custom `OVERRIDE_TARGET_VERSION` environment variable to the desired Node.js version - e.g. `OVERRIDE_TARGET_VERSION=20.11.1`. You find the "Environment Variables" field by expanding "Options >" in the "New Build" dialog. === Backporting diff --git a/package.json b/package.json index 5b974431584e4..25f933644fdc3 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ "url": "https://github.com/elastic/kibana.git" }, "engines": { - "node": "20.10.0", + "node": "20.11.1", "yarn": "^1.22.19" }, "resolutions": { diff --git a/packages/kbn-utils/src/streams/reduce_stream.test.ts b/packages/kbn-utils/src/streams/reduce_stream.test.ts index 25be250865cf8..4b672b2231a76 100644 --- a/packages/kbn-utils/src/streams/reduce_stream.test.ts +++ b/packages/kbn-utils/src/streams/reduce_stream.test.ts @@ -23,9 +23,9 @@ describe('reduceStream', () => { }, 0), ]); expect(stub).toHaveBeenCalledTimes(3); - expect(stub.mock.calls[0]).toEqual([0, 1, 'utf8']); - expect(stub.mock.calls[1]).toEqual([1, 2, 'utf8']); - expect(stub.mock.calls[2]).toEqual([2, 3, 'utf8']); + expect(stub.mock.calls[0]).toEqual([0, 1]); + expect(stub.mock.calls[1]).toEqual([1, 2]); + expect(stub.mock.calls[2]).toEqual([2, 3]); }); test('provides the return value of the last iteration of the reducer', async () => { diff --git a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap index 837cee1a78aff..eb243025df2f7 100644 --- a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap +++ b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap @@ -148,6 +148,7 @@ exports[`Inspector Data View component should render loading state 1`] = ` "_eventsCount": 0, "_maxListeners": undefined, "_tables": Object {}, + Symbol(shapeMode): false, Symbol(kCapture): false, }, } diff --git a/src/plugins/unified_histogram/public/container/hooks/use_state_props.test.ts b/src/plugins/unified_histogram/public/container/hooks/use_state_props.test.ts index d32235f06f356..15c1ef83a4b8c 100644 --- a/src/plugins/unified_histogram/public/container/hooks/use_state_props.test.ts +++ b/src/plugins/unified_histogram/public/container/hooks/use_state_props.test.ts @@ -132,6 +132,7 @@ describe('useStateProps', () => { "_eventsCount": 0, "_maxListeners": undefined, "requests": Map {}, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "searchSessionId": "123", @@ -212,6 +213,7 @@ describe('useStateProps', () => { "_eventsCount": 0, "_maxListeners": undefined, "requests": Map {}, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "searchSessionId": "123", @@ -313,6 +315,7 @@ describe('useStateProps', () => { "_eventsCount": 0, "_maxListeners": undefined, "requests": Map {}, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "searchSessionId": "123", @@ -390,6 +393,7 @@ describe('useStateProps', () => { "_eventsCount": 0, "_maxListeners": undefined, "requests": Map {}, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "searchSessionId": "123", diff --git a/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts index fa5be0e332330..5a8b522c4e447 100644 --- a/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts +++ b/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts @@ -83,6 +83,7 @@ describe('requestOAuthClientCredentialsToken', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, diff --git a/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts index c096212af440e..96d024047566e 100644 --- a/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts +++ b/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts @@ -84,6 +84,7 @@ describe('requestOAuthJWTToken', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, diff --git a/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts index cc7d6d5e4822d..46b9d356e7729 100644 --- a/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts +++ b/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts @@ -91,6 +91,7 @@ describe('requestOAuthToken', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, diff --git a/x-pack/plugins/stack_connectors/server/connector_types/email/send_email_graph_api.test.ts b/x-pack/plugins/stack_connectors/server/connector_types/email/send_email_graph_api.test.ts index 40c282103f17c..03289b79c3004 100644 --- a/x-pack/plugins/stack_connectors/server/connector_types/email/send_email_graph_api.test.ts +++ b/x-pack/plugins/stack_connectors/server/connector_types/email/send_email_graph_api.test.ts @@ -104,6 +104,7 @@ describe('sendEmailGraphApi', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, @@ -113,7 +114,7 @@ describe('sendEmailGraphApi', () => { "validateStatus": [Function], }, ] - `); + `); }); test('email was sent on behalf of the user "from" mailbox', async () => { @@ -195,6 +196,7 @@ describe('sendEmailGraphApi', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, @@ -204,7 +206,7 @@ describe('sendEmailGraphApi', () => { "validateStatus": [Function], }, ] - `); + `); }); test('sendMail request was sent to the custom configured Graph API URL', async () => { @@ -285,6 +287,7 @@ describe('sendEmailGraphApi', () => { "scheduling": "lifo", "sockets": Object {}, "totalSocketCount": 0, + Symbol(shapeMode): false, Symbol(kCapture): false, }, "maxContentLength": 1000000, @@ -294,7 +297,7 @@ describe('sendEmailGraphApi', () => { "validateStatus": [Function], }, ] - `); + `); }); test('throw the exception and log the proper error if message was not sent successfuly', async () => { diff --git a/x-pack/plugins/synthetics/public/apps/synthetics/state/manual_test_runs/api.ts b/x-pack/plugins/synthetics/public/apps/synthetics/state/manual_test_runs/api.ts index 4e8a98af719dc..ebac31a5b8a4d 100644 --- a/x-pack/plugins/synthetics/public/apps/synthetics/state/manual_test_runs/api.ts +++ b/x-pack/plugins/synthetics/public/apps/synthetics/state/manual_test_runs/api.ts @@ -16,7 +16,7 @@ export const triggerTestNowMonitor = async ({ configId: string; name: string; }): Promise => { - return await apiService.get(SYNTHETICS_API_URLS.TRIGGER_MONITOR + `/${configId}`); + return await apiService.post(SYNTHETICS_API_URLS.TRIGGER_MONITOR + `/${configId}`); }; export const runOnceMonitor = async ({ diff --git a/x-pack/plugins/synthetics/server/routes/synthetics_service/test_now_monitor.ts b/x-pack/plugins/synthetics/server/routes/synthetics_service/test_now_monitor.ts index c2569153ce94d..fcc8b30d71a5f 100644 --- a/x-pack/plugins/synthetics/server/routes/synthetics_service/test_now_monitor.ts +++ b/x-pack/plugins/synthetics/server/routes/synthetics_service/test_now_monitor.ts @@ -16,7 +16,7 @@ import { SYNTHETICS_API_URLS } from '../../../common/constants'; import { normalizeSecrets } from '../../synthetics_service/utils/secrets'; export const testNowMonitorRoute: SyntheticsRestApiRouteFactory = () => ({ - method: 'GET', + method: 'POST', path: SYNTHETICS_API_URLS.TRIGGER_MONITOR + '/{monitorId}', validate: { params: schema.object({ diff --git a/x-pack/test/api_integration/apis/synthetics/test_now_monitor.ts b/x-pack/test/api_integration/apis/synthetics/test_now_monitor.ts index 400e073f8a3f3..913a4dedc9541 100644 --- a/x-pack/test/api_integration/apis/synthetics/test_now_monitor.ts +++ b/x-pack/test/api_integration/apis/synthetics/test_now_monitor.ts @@ -38,7 +38,7 @@ export default function ({ getService }: FtrProviderContext) { const resp = await monitorTestService.addMonitor(newMonitor); const res = await supertest - .get(SYNTHETICS_API_URLS.TRIGGER_MONITOR + `/${resp.id}`) + .post(SYNTHETICS_API_URLS.TRIGGER_MONITOR + `/${resp.id}`) .set('kbn-xsrf', 'true') .expect(200); @@ -79,7 +79,7 @@ export default function ({ getService }: FtrProviderContext) { .expect(200); const res = await supertest - .get(`/s/${SPACE_ID}${SYNTHETICS_API_URLS.TRIGGER_MONITOR}/${resp.body.id}`) + .post(`/s/${SPACE_ID}${SYNTHETICS_API_URLS.TRIGGER_MONITOR}/${resp.body.id}`) .set('kbn-xsrf', 'true') .expect(200);