wip: refactor to use only react context + render props #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkrolick
force-pushed
the
proposal--init-as-parent
branch
from
086f477 to
f496afd
Compare
alexkrolick
force-pushed
the
proposal--init-as-parent
branch
from
f496afd to
6a2fee4
Compare
alexkrolick
added a commit
that referenced
this pull request
Aug 27, 2018
Gets rid of the singleton store and observable dependency in favor of React context + nesting The most basic way to use this is just using a render prop that accepts state + setState and is almost the same as State from react-powerplug, but the whitespace limitations make it very difficult to work with. Providing the values as context seems cleaner for more complex documents even if it requires more local nesting. See demo/counter-child-function.mdx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of the singleton store and observable dependency in favor of React context + nesting
The most basic way to use this is just using a render prop that accepts state + setState and is almost the same as
Statefromreact-powerplug, but the whitespace limitations make it very difficult to work with. Providing the values as context seems cleaner for more complex documents even if it requires more local nesting. Seedemo/counter-child-function.mdx.