Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Fix settings typings #489

Open
alexkrechik opened this issue May 24, 2024 · 0 comments
Open

[Tech Debt] Fix settings typings #489

alexkrechik opened this issue May 24, 2024 · 0 comments
Labels
Milestone

Comments

@alexkrechik
Copy link
Owner

Now, settings typings are wrong - we get a lot of default values from the VsCode (based on the package.json), but in the code handling them as possibly undefined.
Also, it would be better to emulate the default settings values set in the tests.

@alexkrechik alexkrechik added this to the 3.1.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant