-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Bundle #10
Comments
I'm currently using
I think it works nicely at the moment. With a prebuilt bundle, Babel is then not needed for developing with hot reloading. |
cbuild is really interesting. I've been wanting to build a very similar thing for a few weeks now. And I'd really like to speak to you about a bit of possible collaboration. I've sent you a PM on gitter. With regards to using it here, I still want to babel/rollup, for the following reasons.
cbuild for me feels like it would be better suited to bundling at the application level |
Yes, it's meant for app level and bundling the reloader was basically a free side effect. If there's a way to create a more minimalistic bundle and with fewer tools, that would be better. |
I think actually that the best way to build this will be with |
I'm experimenting with using jspm bundle in conjunction with systemjs-hmr & systemjs-hot-reloader. It feels like it shouldn't take much changes, but I haven't gotten it working yet. |
Does it complain that it can't find |
If so, add |
Ah, I don't have a build config yet as I am still using the CLI, "jspm bundle". I did "jspm bundle client/**/* - [systemjs-hmr]" and it worked (I'm still on [email protected]). The way I have it working now seems nice. With everything besides systemjs-hmr in the bundle, initial load is fast, and the hot reload works on individual files so I can see changes immediately and keep my state. Still trying to muddle through more issues though (currently having trouble with hot reload getting bugged out once I rebuild the bundle). Ideally I'll have "jspm bundle --watch" going so that I don't have to deal with stale bundled code later when doing a full refresh. |
@mavericken the beta version of |
I am using the --watch flag. Current problem is that as soon as the bundle.js changes, hot reload breaks completely. It seems I can rather easily work around it by just filtering out bundle.js changes, but trying to figure out the actual problem. Edit: I figured it out that bug, fix pull request available here: #13 |
Bundling via rollup |
I want to pass the source files through a rollup (with babel), so that I can get a nice single small bundle.
This will also allow easy usage of something like the babel runtime transform.
If anyone has some time and wants to contribute to this project. This is would appreciated.
The text was updated successfully, but these errors were encountered: