Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Images are spaced around inconsistently (for fish anyways) #17

Open
CephNightmare opened this issue Jul 16, 2020 · 4 comments
Open

Images are spaced around inconsistently (for fish anyways) #17

CephNightmare opened this issue Jul 16, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@CephNightmare
Copy link

CephNightmare commented Jul 16, 2020

Hi,

First of all, thanks for making this API publicly available!

I have a problem with the spacing around the images of the animal.
Is it at all possible to either:

  1. Trim the images so the spacing isn't an issue when sizing the image
  2. As an alternative, at least centering the animal properly. The crucian carp for example isn't centered, so centering in a layout is impossible.

Any help or advice would be greatly appreciated!

@alexislours alexislours added the enhancement New feature or request label Jul 16, 2020
@alexislours
Copy link
Owner

The images are as found in the game files and these endpoint will most likely remain as such. I might add an endpoint down the line with cropped version of these images.

@CephNightmare
Copy link
Author

That would be a great addition! There seems to be an easy way to crop the images using a package: https://www.npmjs.com/package/trim-image

Maybe this would be useful to run for the existing dataset when you intend to look at it?

@alexislours
Copy link
Owner

I already have the cropped images. For every images there is in the game. But thanks for the suggestion. The trouble is more finding the time between work to update the data, add the endpoint and update the doc.

@CephNightmare
Copy link
Author

Fair enough, i'd be willing to help out if you'd like?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants