New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clamp ratio #3

Open

cswhjiang opened this issue Aug 3, 2017 · 1 comment

cswhjiang commented Aug 3, 2017

It seems that you should clamp ratio, not surr1.

https://github.com/alexis-jacq/Pytorch-DPPO/blob/master/ppo.py#L145

Owner

alexis-jacq commented Aug 3, 2017

Thanks a lot! I did not see this typo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment