From 604be8d1c2129f97ce1135ade60ba55f3014cd89 Mon Sep 17 00:00:00 2001 From: Alexey Tikhonov Date: Wed, 4 Sep 2024 12:09:53 +0200 Subject: [PATCH] CONFDB: move sanity check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closer to a place where argument is really used Reviewed-by: Alejandro López Reviewed-by: Pavel Březina --- src/confdb/confdb.c | 5 +++++ src/tools/common/sss_tools.c | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c index 21e96634e61..252c557ce9a 100644 --- a/src/confdb/confdb.c +++ b/src/confdb/confdb.c @@ -650,6 +650,11 @@ int confdb_init(TALLOC_CTX *mem_ctx, int ret = EOK; mode_t old_umask; + if (cdb_ctx == NULL) { + DEBUG(SSSDBG_FATAL_FAILURE, "Bad argument\n"); + return EFAULT; + } + cdb = talloc_zero(mem_ctx, struct confdb_ctx); if (!cdb) return ENOMEM; diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c index d5d4b5f6a47..236a7498ad9 100644 --- a/src/tools/common/sss_tools.c +++ b/src/tools/common/sss_tools.c @@ -93,11 +93,6 @@ errno_t sss_tool_confdb_init(TALLOC_CTX *mem_ctx, struct confdb_ctx **_confdb) errno_t ret; struct stat statbuf; - if (_confdb == NULL) { - DEBUG(SSSDBG_FATAL_FAILURE, "Bad argument\n"); - return EFAULT; - } - ret = stat(path, &statbuf); if (ret != 0) { ret = errno;