Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect features for musl #157

Open
havasd opened this issue Sep 22, 2022 · 0 comments
Open

Automatically detect features for musl #157

havasd opened this issue Sep 22, 2022 · 0 comments

Comments

@havasd
Copy link

havasd commented Sep 22, 2022

I have a similar use-case as well like in #151.
But based on the way it looks it is unlikely that this is a suitable solution. At least I couldn't get it to work.
Could you please elaborate how does this change supposed to work?

Because based on the usages this crate is always built in other crates. I.e.: In case of openssl-sys they are calling directly the Build in lib.rs. So I don't think it goes through the normal means of cargo build facilities (build.rs). I think this feature-flag would only be controllable in Cargo.toml if we would have the normal build procedure. (correct me if I am wrong)

Ideally I could think 2 ways to fix this problem:

  • Export this feature all the way and make it possible to customize the Build section from openssl-sys
  • Add sample test programs which can decide wether the current platform supports such facilities which are disabled by default on musl or windows (probably this one is more robust)
    What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant