Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom repository url #1

Closed
ilopmar opened this issue May 17, 2014 · 5 comments
Closed

Custom repository url #1

ilopmar opened this issue May 17, 2014 · 5 comments
Labels

Comments

@ilopmar
Copy link

ilopmar commented May 17, 2014

Hi,

I'm trying your plugin and I think it's great. I'm using a custom repository url as my project is neither in github nor in bitbucket.

I've defined the custom url like this:

https://git.my-company.com/<%- project %>/<%- repo %>/commit/<%- revision %>

But when the url is opened in the browser the generated url is:

https://git.my-company.com///[email protected]:2222/group/repo-name/commit/c0a10505d58ef8563bf06fec9c7de05d61eaf9c2

As you can see the //[email protected]:2222/ is not right. If I remove this part from the url the link is generated correctly.

Is there any way I can define the custom url without the ssh url that I use to push to the repo?

Regards, Iván.

@alexcorre alexcorre added the bug label May 17, 2014
@alexcorre
Copy link
Owner

I think I know whats going on here. I think my RegExp in this line is not smart enough to parse out your group and repo name.

see: RemoteRevision.js#L52

I use the repository remote url from git remote -v to attempt to parse out the project (or some call it group) name and the repo name, but I didnt anticipate ports on the url.

I'm guessing your remote url looks something like...

[email protected]:2222:group/repo-name.git

I should have a fix for this pretty soon...

@alexcorre
Copy link
Owner

Can you give me an example or your remote url? so I can ensure it works?

@ilopmar
Copy link
Author

ilopmar commented May 17, 2014

Thank you for your quick reply.

My remote url is:

ssh://[email protected]:2222/group/repo-name.git

@alexcorre
Copy link
Owner

Published in v0.2.1 which should contain the fix.

@ilopmar
Copy link
Author

ilopmar commented May 20, 2014

I've updated the plugin and now it's working :-)

Thank you very much!

Regards, Iván.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants