Fix for iPad split view bug #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexaubry after testing it in my own app, this PR fixes the problem. |
|
@a2 @alexaubry Any update? |
alexisakers
approved these changes
Feb 16, 2020
|
I am also facing the same issue with split view and dismiss animation, and wanted to know when will this be merged or should I use the specific branch in the meantime |
|
@overlord21 since @alexaubry hasn't merged this PR, I'm using @Piidro 's fork in production. I know it's not ideal, but it's the only solution right now. |
|
Hi here, sorry for the delay merging this, had to deal with other problems. Will make a new release. |
alexisakers
added a commit
that referenced
this pull request
May 14, 2020
* Fix for iPad split view bug (#173) * Fixed the iPad animation bug when bulletin shown, also couple deprecation warnings * Updated Changelog * Corrected the available -check * Remove project resources * Update CHANGELOG Co-authored-by: Petri Tilli <[email protected]> Co-authored-by: Alexis Aubry <[email protected]>
|
The fix was released in 4.1.1, thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
This fixes the issue #172
Changes were tested with the example application provided.
Description
Fix was done by setting the correct frame in the
BulletinPresentationAnimationControllerwhen animating the view in. Also fixed couple activity indicator style deprecation warnings.