Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Events are not parsed by model #121

Closed
ts8ta opened this issue Jun 14, 2018 · 7 comments
Closed

Input Events are not parsed by model #121

ts8ta opened this issue Jun 14, 2018 · 7 comments

Comments

@ts8ta
Copy link

ts8ta commented Jun 14, 2018

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

SDK 2.0: Input Events of Echo Buttons are not provided in RequestEnvelope correctly.

If you press a button, the incoming event object does not match the structure of json and values if InputEvents are all null. Since the model is not public, I cannot extend the model myself in an appropriate way.

Please fix, we need this as soon as possible.

Details:

Expected Behavior

Example flow is described here: https://developer.amazon.com/de/docs/gadget-skills/discover-echo-buttons.html
When I press an Echo Button, I should receive an event containing information about the buttons pressed.

Current Behavior

I am receiving an event with a request of type GameEngine.InputHandlerEvent but the data for Input Events is not filled in Java.
Checking the json sent to my service, I can see that the data is included.

Steps to Reproduce (for bugs)

Implement the example of https://developer.amazon.com/de/docs/gadget-skills/discover-echo-buttons.html with sdk version 2.3.2 and notice that the data is not filled into java objects

Possible Solution

I think the model is not parsing the relevant information right now, so the model needs to be updated.

Context

I am trying to build a game with Echo Buttons but cannot get the buttons, so I cannot build my game.

Your Environment

  • ASK Java SDK version used: 2.3.2

Java Info

  • Java version used for development: 1.8
@sungolivia
Copy link
Contributor

Hi there, do you mind trying to fill out the issue template as much as possible? Even snippets of code showing what you are trying to do, SDK version helps a lot as well and may get this issue resolved faster while we are working on it. Thanks!

@ts8ta
Copy link
Author

ts8ta commented Jun 14, 2018

Hi @sungolivia I updated my description above. Let me know if you need more information on this
Thanks!

@sungolivia
Copy link
Contributor

Hey @ts8ta, this issue should be fixed with release #2.3.4 . Closing this issue but feel free to reopen if bug is still there!

@ts8ta
Copy link
Author

ts8ta commented Jun 15, 2018

Hi @sungolivia I can confirm this is working now using #2.3.4
Thanks!

@ts8ta
Copy link
Author

ts8ta commented Jun 15, 2018

Hey @sungolivia sorry, but I need to reopen this. In my test app, I can see that the values are set correctly, but there are not getters to read those from Request (com.amazon.ask.model.Request)

Could you please check any maybe re-open?

@breedloj
Copy link
Contributor

Request is generic. If you've written a handler that works against incoming InputHandlerEventRequests you'll want to cast the request to that type to get access to its methods. This is what I did when testing this out yesterday.

@ts8ta
Copy link
Author

ts8ta commented Jun 15, 2018

yep, this works. Thanks @breedloj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants