Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CLI Flag Specifying Config File #59

Closed
Tracked by #84
0x0D15 opened this issue Jan 8, 2023 · 4 comments
Closed
Tracked by #84

Feature: CLI Flag Specifying Config File #59

0x0D15 opened this issue Jan 8, 2023 · 4 comments
Labels
feature New feature or request

Comments

@0x0D15
Copy link

0x0D15 commented Jan 8, 2023

Would you consider adding a flag that disables the config file searching behavior described here and just reads the specified file?

And thanks for writing this, its certainly an improvement over the existing utilities in the space.

@alex-courtis alex-courtis added feature New feature or request good first issue labels Jan 9, 2023
@alex-courtis
Copy link
Owner

That sounds fine. I can imagine some use cases.

PRs are gratefully accepted.

@alex-courtis
Copy link
Owner

Added option:

  -c, --c[onfig]        <path>

I would be most grateful if you could test this prior to release:

git clone [email protected]:alex-courtis/way-displays.git
cd way-displays
make
./way-displays --help
./way-displays --config /path/to/my/config.yaml

@0x0D15
Copy link
Author

0x0D15 commented Mar 3, 2023

Works perfectly, thanks for taking the time.

As a side note, it seems like VRR is now added and always on for river? Would it be possible to add some per monitor toggle for it? I can open a new issue if that works better.

@alex-courtis
Copy link
Owner

Thanks for testing.

As a side note, it seems like VRR is now added and always on for river? Would it be possible to add some per monitor toggle for it? I can open a new issue if that works better.

Please do. I applied YAGNI when adding VRR, however now we do need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants