add --keep argument to allow test resources to be kept #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttle of resource creation)
agwhi
reviewed
May 16, 2021
agwhi
reviewed
May 16, 2021
agwhi
reviewed
May 16, 2021
| @@ -87,6 +92,8 @@ export default class EventBridge { | |||
| }) | |||
| .promise(); | |||
|
|
|||
| await this.getEvents(); // need to clear this manual published event from the SQS observer queue. | |||
There was a problem hiding this comment.
Do we always want to delete the events?
It could be worth splitting this into two functions (eg. peekEvents, popEvents).
We would have to set the VisibilityTimeout to 0 when we create the queue so that peek doesn't change the visibly
agwhi
approved these changes
May 16, 2021
agwhi
pushed a commit
that referenced
this pull request
May 21, 2021
add --keep argument to allow test resources to be kept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--keep=trueargument to enable testing resources (like SQS queue for EventBridge) to be kept.This was triggered by throttling of queue creation after deletion on repeated runs.
Note, also removed bugs in messages being left on the SQS queue when events added to EventBridge via manual publish via
sls-test-tools.