Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Support virtual filesystems #500

Closed
TylerLeonhardt opened this issue May 5, 2021 · 10 comments
Closed

[FEATURE] - Support virtual filesystems #500

TylerLeonhardt opened this issue May 5, 2021 · 10 comments
Labels
enhancement remote Remote Development vscode api adoption Adopting new/updated VS Code APIs
Milestone

Comments

@TylerLeonhardt
Copy link

In preview (vscode-insiders only), there are now a concept of "Remote repositories" (see release notes which allows you to instantly browse, search, edit, and commit to any GitHub repository directly from within VS Code without having to clone or have the repository locally.
RemoteHub is a new feature in vscode insiders... It allows you to open a virtual filesystem of a GitHub repo.

  1. Click the remote development button on the bottom right of vscode
  2. Click RemoteHub: Open GitHub Repository...
  3. Paste in a url of a GitHub repo and it's open a virtual filesystem of that repo
    For example, my https://github.com/TylerLeonhardt/vscode-autountitledlanguage is represented as:
    vscode-vfs://github/TylerLeonhardt/vscode-autountitledlanguage
    I tried putting this in as the root path but no luck:
    image
    my guess is that vscode-project-manager just doesn't handle this scheme properly and think's it's a file path.
@alefragnani
Copy link
Owner

Hi @TylerLeonhardt ,

Yep, this happens because its scheme is not vscode-remote, so it thinks to be local. I think it would be fairly easy to update the extension to support it.

Just out of curiosity, is this new built-in Remote Hub extension based/the same one from @eamodio? I just noticed it has basically the same concept (and name) and its repo is now archived.

BTW, do you have any suggestion for its icon? 😬

@alefragnani alefragnani added remote Remote Development enhancement and removed enhancement labels May 5, 2021
@TylerLeonhardt
Copy link
Author

Yep! @eamodio has it built in to VS Code now 😁

@TylerLeonhardt
Copy link
Author

I think for an icon, it should be like...Something that represents a virtual filesystem like maybe the cloud or globe or rss

@alefragnani
Copy link
Owner

The cloud icon was the first one in my mind. I think it's a good choice.

Thank you

@eamodio
Copy link

eamodio commented May 6, 2021

Yeah, Remote Repositories (RemoteHub) is based on my previous RemoteHub idea, but also expands on it greatly to encompass a much richer VS Code environment -- with editing and SCM support. And we're just getting started 😁

@alefragnani
Copy link
Owner

I knew it 😆

@alefragnani
Copy link
Owner

I'm wondering if I should use cloud or remote codicon for this 😬

Screen Shot 2021-05-07 at 13 19 28

BTW, I didn't understand why the extension was "internally" disabled for Virtual Workspaces. Just added the proper capabilities entry on package.json and it appears to be working just fine. I'm a bit confuse because it has the same extensionKind as my other Bookmarks extension, and that one wasn't disabled (and is working just fine 🎉 ). About that, I'm going to ask/comment on that tracking issue about disabled functionalities. If you could take a look/help, it would be great.

Well, proper support should be available in the next release. Stay tuned

@TylerLeonhardt
Copy link
Author

BTW, I didn't understand why the extension was "internally" disabled for Virtual Workspaces.

So I didn't do this but someone on the team took the top X extensions and decided if they should be enabled by default. I don't know the reasoning, I might have made the same choice since you couldn't "save a virtual filesystem". But as you've found out, you have the power to override that default so you should be good to go with the next release :)

Plus once this ships, I'll make sure that default is removed for bookkeeping purposes. Sorry for that confusion!

@TylerLeonhardt
Copy link
Author

I'm wondering if I should use cloud or remote codicon for this 😬

Remote does look prettttty nice!

@alefragnani
Copy link
Owner

No problem about being disabled. It was just me being curious 😬.

In the end is good that way because forces me (and other extension developer) to properly evaluate/test the extension, before enabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement remote Remote Development vscode api adoption Adopting new/updated VS Code APIs
Projects
None yet
Development

No branches or pull requests

3 participants