Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to save a project when no folder is open gives confusing message #191

Closed
nicktimko opened this issue Jun 1, 2018 · 3 comments
Closed
Labels
Milestone

Comments

@nicktimko
Copy link

I lazily did a code in a folder that I didn't have saved maybe thinking it'd be like code . then when trying to quickly save that project, I got the confusing error

Running the contributed command:'projectManager.saveProject' failed.

Steps to reproduce

  1. Open a VSCode window with no folders open
  2. Open control palette and try to "Save Project"
  3. VSCode emits warning

Expected behavior

Warn the user "Hey idiot, you don't have a folder open" or something more friendly. The VSCode warning started making me check if things were up to date...

Details

  • VSCode 1.23.1
  • Ubuntu 16.04
  • VSPM: 0.25.2
@nicktimko nicktimko changed the title Trying to save a project when no folder is open gives misleading message Trying to save a project when no folder is open gives confusing message Jun 1, 2018
@alefragnani
Copy link
Owner

Hi @nicktimko ,

Warn the user "Hey idiot, you don't have a folder open" or something more friendly. The VSCode warning started making me check if things were up to date...

I'm going for the friendly message 😆 .

Thanks for reporting

@alefragnani alefragnani added the bug label Jun 6, 2018
@alefragnani alefragnani added this to the 8.0 milestone Jul 4, 2018
@BlueTalon6
Copy link

It looks like this check and prompt has been removed in a later version?
Had some code open and tried to save a project with 12.7, without having a folder open and got "Error running command projectManager.saveProject.. something about property of undefined".
Updated VSC to 1.77.3 and now there's no prompt or error.

@alefragnani
Copy link
Owner

Hi @BlueTalon6 ,

I could reproduce the issue. Really weird this is not working anymore, as the source responsible for it is not changed for a while.

This should be fixed in the next release

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants