Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bookmarks creation in Jupyter files (.ipynb) #294

Closed
JoopBanaan opened this issue May 1, 2020 · 2 comments
Closed

allow bookmarks creation in Jupyter files (.ipynb) #294

JoopBanaan opened this issue May 1, 2020 · 2 comments
Labels
depends on Depends on issues from VS Code duplicate enhancement

Comments

@JoopBanaan
Copy link

I like to create bookmarks as well in Jupyter files (extension .ipynb)
Currently (version 11.1) I get a pop up "open a file first to toggle bookmarks"

@alefragnani
Copy link
Owner

Hi @JoopBanaan ,

I’m not aware about how Jupyter Notebooks works, but looking at VS Code announcement (https://code.visualstudio.com/docs/python/jupyter-support) and looking it open issues in VS Code repository, it seems to be a WebView with some pieces of editable source code, so I guess you are trying to add bookmarks in that editable source code, right?

If that’s the case, I guess this issue recently opened in VS Code repository may be the reason (microsoft/vscode#96532). BTW, the Notebook API is still in early stages (microsoft/vscode#93265 api-proposal to be precise), so it would take some time (at least May, based on the milestone attached to the issue) to have something to work with.

I just wonder how each ActiveTextEditor will be announced for extensions, because today, each one refers to one file in file system, and with Jupyter Notebook, it could end up with many ActiveTextEditor referring to the same file in file system.

So, I need to help at least until May/June, after the oficial API is released, to take a look at this.

Hope this helps

@alefragnani
Copy link
Owner

I’m closing as duplicate of #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on Depends on issues from VS Code duplicate enhancement
Projects
None yet
Development

No branches or pull requests

2 participants