Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword import is reserved #61

Closed
shavo007 opened this issue Dec 7, 2016 · 4 comments
Closed

keyword import is reserved #61

shavo007 opened this issue Dec 7, 2016 · 4 comments

Comments

@shavo007
Copy link

shavo007 commented Dec 7, 2016

Hi,

I just recently added this module for my protractor tests.

I installed es-lint and eslint-plugin-protractor.
"eslint": "^3.11.1", "eslint-plugin-protractor": "^1.30.0",

I am using ATOM as my IDE. I installed the package linter-eslint.

The config in eslintrc is

{ "plugins": [ "protractor" ], "extends": "plugin:protractor/recommended" }

When i saved my spec file I get this error. My specs are defined using es6. So not sure why this is an error.

Thanks,
Shane.

@alecxe
Copy link
Owner

alecxe commented Dec 8, 2016

@shavo007 thanks for using the library (at least trying :)). This looks like a generic ESLint problem, not specific to the plugin, but let's see what can help.

This looks relevant:

Please see if any of these links help.

@shavo007
Copy link
Author

shavo007 commented Dec 8, 2016

Awesome.

I installed babel-eslint and in the config file added the entry:

"parser": "babel-eslint"

Now i see all the nice warnings i have!!! ;-)

@shavo007 shavo007 closed this as completed Dec 8, 2016
@alecxe
Copy link
Owner

alecxe commented Dec 8, 2016

@shavo007 thanks! I would really appreciate the feedback, feel free to create feature requests or request improvements or send the pull requests.

Most of the implemented or planned ideas are coming from the styleguide, personal experience or undergoing work projects and sometimes from stackoverflow real world use cases - I wish I had more real-world usages of the plugin and ideas to develop new rules to check the Protractor tests.

@shavo007
Copy link
Author

shavo007 commented Dec 8, 2016

no worries @alecxe happy to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants