fix(rules): fix empty CSS selector input for 'no-bootstrap-classes' a…

…nd 'no-angular-classes' rules
alecxe · Jul 17, 2016 · b4e3cbf · b4e3cbf
1 parent 4bf1ae6
commit b4e3cbf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/lib/extract-class-names.js b/lib/extract-class-names.js
@@ -42,11 +42,14 @@ module.exports = function (cssSelector) {
     return []
   }
 
+  // handling empty inputs
+  if (!result) {
+    return []
+  }
+
   var classNames = []
 
-  if (result.type === 'rule') {
-    classNames = extractClassNames(result.rule)
-  } else if (result.type === 'ruleSet') {
+  if (result.type === 'ruleSet') {
     var rule = result.rule
     while (rule) {
       classNames.push.apply(classNames, extractClassNames(rule))

diff --git a/test/rules/no-bootstrap-classes.js b/test/rules/no-bootstrap-classes.js
@@ -26,7 +26,9 @@ eslintTester.run('no-bootstrap-classes', rule, {
     '$("p::first-line");',
     '$("invalid::selector()");',
     '$("a[href^=/], .container:has(nav) > a[href]:lt($var)");',
-    '$$("//somethinginvalid[@attr=\'test\']")'
+    '$$("//somethinginvalid[@attr=\'test\']")',
+    'element(by.css("a[href]"));',
+    '$("");'
   ],
 
   invalid: [