fix(rules): fix the empty argument 'valid-locator-type' rule problem (#…

…56)
alecxe · Nov 14, 2016 · 65a6b5c · 65a6b5c
1 parent 1bb1139
commit 65a6b5c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/rules/valid-locator-type.js b/lib/rules/valid-locator-type.js
@@ -57,7 +57,7 @@ function is$$ (node) {
  * @returns {boolean}
  */
 function isArgumentLiteral (node) {
-  return node.arguments && node.arguments[0].type === 'Literal'
+  return node.arguments && node.arguments.length && node.arguments[0].type === 'Literal'
 }
 
 /**
@@ -67,7 +67,7 @@ function isArgumentLiteral (node) {
  * @returns {boolean}
  */
 function isArgumentByLocator (node) {
-  if (node.arguments && node.arguments[0].type === 'CallExpression') {
+  if (node.arguments && node.arguments.length && node.arguments[0].type === 'CallExpression') {
     var argument = node.arguments[0]
     if (argument.callee && argument.callee.object && argument.callee.object.name === 'by') {
       return true

diff --git a/test/rules/valid-locator-type.js b/test/rules/valid-locator-type.js
@@ -19,7 +19,15 @@ eslintTester.run('valid-locator-type', rule, {
     '$$(".class1").all(by.css(".class2"));',
     '$(".class1").$(".class2");',
     '$(".class1").$$(".class2");',
-    '$$(".class1").$$(".class2");'
+    '$$(".class1").$$(".class2");',
+    'element();',
+    'element(somevariable);',
+    'element.all();',
+    'element.all(somevariable);',
+    '$$(".class1").$$();',
+    '$$(".class1").$$(somevariable);',
+    '$();',
+    '$(somevariable);'
   ],
 
   invalid: [