Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc/builder: figure out gas estimation for aggregated ops #219

Closed
Tracked by #935
dancoombs opened this issue May 10, 2023 · 1 comment · Fixed by #980
Closed
Tracked by #935

rpc/builder: figure out gas estimation for aggregated ops #219

dancoombs opened this issue May 10, 2023 · 1 comment · Fixed by #980
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dancoombs
Copy link
Collaborator

dancoombs commented May 10, 2023

Describe the feature
We currently don't support signature aggregation due to gas estimation/attribution issues. Currently nobody would pay for the aggregated signature validation, and the bundler doesn't take this into account when estimating the gas of its bundle.

A potential way to fix this:

  • estimateUserOperationGas needs to be aggregator aware
  • Rundler maintains a whitelist of signature aggregator contracts
  • Each entry encodes a fixed cost + variable cost for each aggregator
  • When estimating, we call simulateValidation to get the aggregator_info
  • If populated, check whitelist. Not whitelisted, reject. If whitelisted
    • Add fixed_cost / BUNDLE_TARGET + variable_cost to the preVerificationGas
    • BUNDLE_TARGET can be set per aggregator. Bundles smaller than the target: the bundler loses money, bundles larger than the target: the bundler makes money
@dancoombs dancoombs added enhancement New feature or request needs-triage Issue needs triage labels May 10, 2023
@dancoombs dancoombs removed the needs-triage Issue needs triage label May 10, 2023
@dancoombs dancoombs added this to the 0.1.0 milestone May 10, 2023
@dancoombs dancoombs removed this from the 0.1.0 milestone Jun 14, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 22, 2023
@dancoombs dancoombs removed the stale label Sep 22, 2023
@dancoombs dancoombs added the prevent-stale Prevent an issue from closure due to being stale label Sep 28, 2023
@dancoombs dancoombs removed their assignment Sep 28, 2023
@dancoombs dancoombs added this to the v0.5 milestone Oct 29, 2024
@dancoombs dancoombs modified the milestones: v0.5, v0.6 Dec 13, 2024
@dancoombs dancoombs self-assigned this Dec 13, 2024
@dancoombs dancoombs removed the prevent-stale Prevent an issue from closure due to being stale label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant