Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pool] Issue with gas efficiency check for v0.6 using a paymaster #976

Open
dancoombs opened this issue Jan 22, 2025 · 0 comments
Open

[pool] Issue with gas efficiency check for v0.6 using a paymaster #976

dancoombs opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dancoombs
Copy link
Collaborator

Describe the bug
The check incorporates a post op estimated cost of 2*VGL, even if a post op isn't used, if VGL >> CGL, and a post op isn't used at all, then gas eff will be low.

To reproduce
Send a UO with the properties above and a gas limit eff of 15%, typically triggers and rejects the UO.

Expected behavior
This shouldn't reject the UO, for v0.6 we shouldn't include the post op gas at all in this calculation.

@dancoombs dancoombs added the bug Something isn't working label Jan 22, 2025
@dancoombs dancoombs added this to the v0.5 milestone Jan 22, 2025
@dancoombs dancoombs self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant