Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal alacritty missing #1450

Closed
findlayjy opened this issue Oct 7, 2024 · 16 comments
Closed

Terminal alacritty missing #1450

findlayjy opened this issue Oct 7, 2024 · 16 comments

Comments

@findlayjy
Copy link

No description provided.

@ManuelSchneid3r
Copy link
Member

ManuelSchneid3r commented Oct 7, 2024

please post the filename of its desktop entry. (the one in /usr/share/applications)

@findlayjy
Copy link
Author

com.alacritty.Alacritty.desktop

@HarshNarayanJha
Copy link

Not missing for me. It is there in the options

@ManuelSchneid3r
Copy link
Member

Depends on the distro I guess

@HarshNarayanJha
Copy link

HarshNarayanJha commented Oct 8, 2024

It should not.

Please post the contents of com.alacritty.Alacritty.desktop AND the application plugin settings (in albert)? (like which options are checked or not)?

@findlayjy
Copy link
Author

[Desktop Entry]
Type=Application
TryExec=alacritty
Exec=alacritty
Icon=com.alacritty.Alacritty
Terminal=false
Categories=System;TerminalEmulator;

Name=Alacritty
GenericName=Terminal
Comment=A fast, cross-platform, OpenGL terminal emulator
StartupWMClass=Alacritty
Actions=New;

[Desktop Action New]
Name=New Terminal
Exec=alacritty

2024-10-08_10-01

@ManuelSchneid3r
Copy link
Member

The desktop id is based on the filename.

@HarshNarayanJha
Copy link

Hey @findlayjy
Try checking Use Exec and Use Keywords for lookup.

@findlayjy
Copy link
Author

Thanks @HarshNarayanJha, but the problem isn't that Albert can't find Alacritty (it can), it's that it doesn't appear in the dropdown "Terminal" menu, so that when I e.g. 'Open terminal here' on an Albert search result, it will open Kitty or the Gnome terminal rather than Alacritty

@findlayjy
Copy link
Author

The desktop id is based on the filename.

Sorry, is this intended as something I should action somehow?

@ManuelSchneid3r
Copy link
Member

Lacking a standard for the script execution commandline interface of the terminals out in the wild we have to hardcode the parameters the terminals use. If you want this change this vote on my pull request. If your terminal broke the command line interface in the past and you are on the old version you are out of luck. Thats why we need that standard. However for as long as this PR is not merged we have to maintain the hardcoded map of terminals to their arguments (if any).

The map currently resides in https://github.com/albertlauncher/plugins/blob/main/applications/src/xdg/plugin.cpp.

If your terminal is not working I need the desktop entry file name (the desktop id) of your terminal and the (xterm -e compatible) argument that indicates that the remainder of the commandline should be interpreted as commandline to run in the terminal. Further the content of the desktop entry may help improving the heuristics currently applied to get the terminals covered.

@findlayjy
Copy link
Author

findlayjy commented Oct 14, 2024

Sorry, I think we're talking in circles a bit :) I provided the desktop entry filename above:

com.alacritty.Alacritty.desktop

And the contents of the desktop entry is in the reply after that:

[Desktop Entry]
Type=Application
TryExec=alacritty
Exec=alacritty
Icon=com.alacritty.Alacritty
Terminal=false
Categories=System;TerminalEmulator;

Name=Alacritty
GenericName=Terminal
Comment=A fast, cross-platform, OpenGL terminal emulator
StartupWMClass=Alacritty
Actions=New;

[Desktop Action New]
Name=New Terminal
Exec=alacritty

The flag that indicates the rest of the line is a command to run in the terminal is -e, so that is correct in the map. The only change would be alacritty -> com.alacritty.Alacritty (although I wonder if sometimes it is installed as just alacritty.desktop so it would be good to keep both?)

ManuelSchneid3r added a commit to albertlauncher/plugins that referenced this issue Oct 15, 2024
ManuelSchneid3r added a commit to albertlauncher/plugins that referenced this issue Oct 16, 2024
@findlayjy
Copy link
Author

The most recent update does not seem to have fixed this. I do now have UXTerm and XTerm in the dropdown menu, but Alacritty is still missing ...

@ManuelSchneid3r
Copy link
Member

/
Please post the logs when running a new albert instance (quit albert before) from terminal using QT_LOGGING_RULES='albert.*=true' albert.

@findlayjy
Copy link
Author

findlayjy commented Oct 19, 2024

21:37:00 �[32m[info:albert]�[0m Searching native plugins in /usr/lib/x86_64-linux-gnu/albert
21:37:00 �[32m[info:albert]�[0m Hotkey set to Alt+Space
21:37:00 �[34m[debg:albert.apps]�[0m Scanning desktop entries in: /home/jamief/.local/share/applications�[0m
21:37:00 �[34m[debg:albert.apps]�[0m Skipped /home/jamief/.local/share/applications/discord-647066573147996161.desktop: Desktop entry excluded by 'NoDisplay'.�[0m
...
21:37:00 �[34m[debg:albert.apps]�[0m Scanning desktop entries in: /usr/local/share/applications�[0m
...
21:37:00 �[34m[debg:albert.apps]�[0m Valid desktop file '/usr/share/applications/debian-uxterm.desktop': 'UXTerm'�[0m
...
21:37:00 �[34m[debg:albert.apps]�[0m Valid desktop file '/usr/share/applications/com.alacritty.Alacritty.desktop': 'Alacritty'�[0m
...
21:37:00 �[34m[debg:albert.apps]�[0m Valid desktop file '/usr/share/applications/kitty.desktop': 'kitty'�[0m
...
21:37:00 �[34m[debg:albert.apps]�[0m Valid desktop file '/usr/share/applications/debian-xterm.desktop': 'XTerm'�[0m
...
21:37:01 �[32m[info:albert.files]�[0m Indexing /home/jamief
21:37:02 �[32m[info:albert.apps]�[0m Indexed 116 applications [43 ms]
21:37:11 �[32m[info:albert]�[0m Received signal 2. Quit.
21:37:12 �[34m[debg:albert.files]�[0m Storing file index to /home/jamief/.cache/albert/files/file_index.json�[0m
21:37:12 �[33m[warn:albert.files]�[0m Busy wait for file indexer.�[0m
21:37:12 �[32m[info:albert]�[0m Bye.

I've redacted the full list. Let me know if that might be relevant. But it definitely finds Alacritty; it just doesn't turn up in the list of terminals:
2024-10-19_21-42

@findlayjy
Copy link
Author

(Just to let you know, this is working now! The icon doesn't show up in the list for whatever reason, but functionally it works! 🥳 Thanks so much for working on this!)
2024-10-29_12-44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants