Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Marble widget URLs containing special characters #479

Closed
albar965 opened this issue Dec 4, 2019 · 12 comments
Closed

Allow Marble widget URLs containing special characters #479

albar965 opened this issue Dec 4, 2019 · 12 comments

Comments

@albar965
Copy link
Owner

albar965 commented Dec 4, 2019

Fix marble widget for example https://www.geoportail.gouv.fr/donnees/carte-oaci-vfr
for URLs containing %2F and &

@albar965 albar965 added this to the Release 2.8 milestone Dec 4, 2019
@albar965 albar965 self-assigned this Dec 4, 2019
@s-celles
Copy link

Hello @albar965,

Coming from https://www.x-plane.fr/showthread.php?t=65933&p=580958&viewfull=1#post580958 and seing also discussions with @ailgorbot at https://forums.x-plane.org/index.php?/files/file/41694-little-navmap/&page=6&tab=comments#comment-286172 I wonder what is current status of this issue.
Is there an issue opened upstream (ie KDE / Marble) ?
https://marble.kde.org/support.php
-> https://bugs.kde.org/enter_bug.cgi?product=marble&component=general&bug_severity=normal
If so could you post link of this issue ?

Kind regards

@albar965
Copy link
Owner Author

There is no upstream issue in Marble.
Status is as the issue says: "Open".

@s-celles
Copy link

Issue opened upstream at https://bugs.kde.org/show_bug.cgi?id=430290
Feel free to add more information

@albar965 albar965 modified the milestones: Release 2.8, Release 3.0 Sep 9, 2021
@albar965 albar965 modified the milestones: Release 3.0, Release 2.8 Jan 26, 2022
@albar965
Copy link
Owner Author

Fixed with albar965/marble@ba4c867 by replacing %3F with ?. Other characters were not affected.

@s-celles
Copy link

Thanks @albar965

@albar965
Copy link
Owner Author

You're welcome. I had to find new maps due to the hillshading debacle and this issue here blocked all usage of API keys or tokens for map servers requiring a registration.
See for screenshots: #85 (comment)

@cowreth
Copy link

cowreth commented May 4, 2022

@scls19fr,

I've made the OACI-fr files you and friends at the x-plane.fr board were looking for.

I don't know if you finally made it on your side, but if not, here's the package.
fr-ign-oaci.zip

(I maybe can cc @h0wardch3ng too)

@s-celles
Copy link

s-celles commented May 5, 2022

Good news thanks! What LNM version are you using?

@s-celles
Copy link

s-celles commented May 5, 2022

@1a57danc3
Copy link

@cowreth @scls19fr Thank you very much, the code has been merged.

@albar965
Copy link
Owner Author

albar965 commented May 5, 2022

@h0wardch3ng I suppose you're continuing the maps from here: https://www.avsim.com/forums/topic/548994-new-maps-for-lnm/

I always had issues with the Google maps showing labels mixed in Dutch, German, English and other languages.
But this can be fixed by adding a language parameter hl=en to the download URL. This will return only map tiles with English labels:

<downloadUrl protocol="https" host="mt1.google.com" path="/vt/lyrs=p&amp;x={x}&amp;y={y}&amp;z={zoomLevel}&amp;hl=en" />
This works for all LNM versions.

The new LNM alpha allows to force the labels to the user interface language by using:
<downloadUrl protocol="https" host="mt1.google.com" path="/vt/lyrs=p&amp;x={x}&amp;y={y}&amp;z={zoomLevel}&amp;hl={language}" />
This works from LNM 2.7 versions.

@s-celles
Copy link

s-celles commented May 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants