-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to nan 2 #23
Comments
I just tried the 1to2.js tool and get a bunch of errors. I am not in a very brave mood, I guess I will wait for the migration guide: nodejs/nan#402 |
Adding to the list: nodejs/node#2798. |
https://nodesource.com/blog/cpp-addons-for-nodejs-v4 appears to be the official migration guide, suggesting |
I made a stab at this, see #26. Users are welcome to try with various node versions and with real life applications. I make no guarantees at all. |
@albanm please bump the version of module with nan 2 to install it from npm. |
Hello, Sorry for not being very present. I am not in a good situation to work at home. We had already talked about it, I just added you as contributor to this project and owner of the package on npm. Feel free to do what is necessary, I will catch up later. |
In libxmljs/libxmljs#330 libxmljs migrated to Nan 2, and in gagern/libxmljs@f6c2c2f libxmljs-mt followed suite. This is causing some build problems, as quite a number of Nan names have changed. I wonder whether it is safe to use Nan 1 and 2 in the same library, but probably wouldn't risk it. Instead I suggest node-libxslt be moved to Nan 2 as well. There is some
1to2.js
script hidden in the Nan directory tree, but so far I had found that thing caused more problems than it addressed.The text was updated successfully, but these errors were encountered: