Ocaml keyword conflicts

[edmcman]

I am using piqi to serialize some language related types. The following type names result in errors when compiling piqi-generated ML code:

• assert
• type
• mod
• and
• or
• let

I am sure there are more; these are only the ones I ran into. It would probably be a good idea to check for any ocaml keywords and disallow them as type or field names in piqi.

[bookshelfdave]

Hello -

I don't work on Piqi, however I had the same issue. See https://gist.github.com/metadave/3195858 for @alavrik's response.

Cheers -
Dave

[alavrik]

Take a look at the @metadave's example. There is a very simple and elegant solution to this practical problem. The use of ocaml-name is also mentioned in the docs.

As for the checks, I think it it would be a nice addition to piqic ocaml.

[edmcman]

Thanks, I like @metadave's example. For me, though, it's just as easy to change the names, because I only use ocaml. I think adding the checks to piqic ocaml is a good idea; it's better to catch the problem early in my opinion.

[alavrik]

Moving this issue to the newly created piqi-ocaml repo.