Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Module 2 hands-on solutions #166

Open
jack89roberts opened this issue Feb 16, 2023 · 0 comments
Open

Improve Module 2 hands-on solutions #166

jack89roberts opened this issue Feb 16, 2023 · 0 comments
Labels
Documentation Improvements or additions to documentation Module 2 Handling Data

Comments

@jack89roberts
Copy link
Contributor

jack89roberts commented Feb 16, 2023

I think the instructions could also be improved/clarified, but the solutions would benefit from some more prose and I think some of the solutions use unnecessarily complex code (especially if we have Python beginners on this course), e.g.

missing = df.groupby("eqls_wave").apply(lambda g: g.isna().mean() * 100).round(3).transpose()

could be:

missing = df.isna().groupby(df["eqls_wave"]).mean()
@jack89roberts jack89roberts added Documentation Improvements or additions to documentation Module 2 Handling Data labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Module 2 Handling Data
Projects
None yet
Development

No branches or pull requests

1 participant