Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.1 Data Consistency - confusing variable name #119

Open
jack89roberts opened this issue Sep 14, 2022 · 0 comments · May be fixed by #161
Open

2.2.1 Data Consistency - confusing variable name #119

jack89roberts opened this issue Sep 14, 2022 · 0 comments · May be fixed by #161
Labels
Module 2 Handling Data

Comments

@jack89roberts
Copy link
Contributor

The smaller_petals variable name here:

# True for each row with body_mass_g greater than the min value of 285g
smaller_petals = df["body_mass_g"] > df["body_mass_g"].min()

# Lowest penguin weight out of all rows with weights above 285g
df.loc[smaller_petals, "body_mass_g"].min()

is a leftover from when this notebook was using the Iris dataset. It should be renamed to something penguin related, e.g. heavier_penguins
@jack89roberts jack89roberts added the Module 2 Handling Data label Sep 14, 2022
@jack89roberts jack89roberts linked a pull request Feb 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module 2 Handling Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Module 2 - post-teaching fixes/tweaks alan-turing-institute/rds-course
1 participant
@jack89roberts