Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variance Reduction is broken. #95

Closed
mikkelbue opened this issue Sep 28, 2021 · 1 comment
Closed

Variance Reduction is broken. #95

mikkelbue opened this issue Sep 28, 2021 · 1 comment
Assignees

Comments

@mikkelbue
Copy link
Collaborator

Description of your problem

Running pytest test_step.py::TestMLDA::test_variance_reduction fails when removing the xfail-decorator. The Q-vector extracted with Q_2 = trace.get_sampler_stats("Q_2").reshape((nchains, ndraws)) seems to be all NaNs.

Complete error traceback
                    # compare standard and VR
>                   assert isclose(Q_mean_standard, Q_mean_vr, rel_tol=1e-1)
E                   assert False
E                    +  where False = isclose(nan, nan, rel_tol=0.1)

test_step.py:1752: AssertionError

Versions and main components

  • PyMC3 Version: Turing development branch: refactor_sample
  • Aesara/Theano Version: 2.2.2
  • Python Version: 3.8.10
  • Operating system: Ubuntu 20.04
  • How did you install PyMC3: (conda/pip): git
@mikkelbue
Copy link
Collaborator Author

Fixed in ebf7f2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants