Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to Angular 8, Nebular 4 #2114

Merged
merged 178 commits into from
Jul 2, 2019
Merged

feat: update to Angular 8, Nebular 4 #2114

merged 178 commits into from
Jul 2, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented May 29, 2019

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

Also closes #2076, #2148

@antonevane
Copy link

nebular 4.0.0 has been released

@Gamarsoft
Copy link

Hi, when is the update of Ngx-admin (demo / starter-kit) planned ? Thx

@YukiDmZhao
Copy link

I git this branch,but can not using,,the style is not normal

@YukiDmZhao
Copy link

feat/update-to-8 ,This verson is not working properly. maybe it is style css or others??

@BobCashStory
Copy link

Nedd update on this please ! :)

@ivan-penchev
Copy link

ivan-penchev commented Jun 13, 2019

Shows
WARNING: Nebular Theme: nb-theme() cannot find value for key color-success for theme default
am I doing something wrong with the branch?

@aksolutions95
Copy link

Shows Errors like
`ERROR in ./src/app/@theme/layouts/one-column/one-column.layout.scss
Module build failed (from ./node_modules/sass-loader/lib/loader.js):

  /deep/ .main-container {
 ^
  Expected selector.


20 │ /deep/ .main-container{
│ ^

stdin 20:7 @content
node_modules@nebular\theme\styles\core\theming_install.scss 116:7 @content
node_modules@nebular\theme\styles\core\theming_install.scss 97:7 nb-install-component-with-scss-vars()
node_modules@nebular\theme\styles\core\theming_install.scss 115:5 nb-install-component()
stdin 5:1 root stylesheet`

with below warnings
Nebular Theme: nb-theme()cannot find value for keybtn-border-radiusfor themecosmic node_modules\@nebular\theme\styles\core\theming\_get-value.scss 59:5 nb-theme() src\app\@theme\styles\bootstrap-rtl.scss 24:37 @content node_modules\@nebular\theme\styles\core\_mixins.scss 312:5 @content node_modules\@nebular\theme\styles\core\_mixins.scss 306:5 _prepend-with-selector() node_modules\@nebular\theme\styles\core\_mixins.scss 311:3 nb-ltr() src\app\@theme\styles\bootstrap-rtl.scss 20:7 bootstrap-rtl() stdin 33:3 @content node_modules\@nebular\theme\styles\core\theming\_install.scss 149:7 @content node_modules\@nebular\theme\styles\core\theming\_install.scss 135:7 nb-install-global-with-scss-vars() node_modules\@nebular\theme\styles\core\theming\_install.scss 148:5 nb-install() stdin 19:1 root stylesheet

Need update of ngx-admin for Angular 8.

@yggg yggg changed the title Feat/update to 8 feat: update to Angular 8, Nebular 4 Jun 24, 2019
@yggg yggg requested a review from Tibing July 2, 2019 08:38
@yggg yggg requested review from yggg and removed request for Tibing July 2, 2019 12:23
@yggg yggg merged commit e9600b4 into master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on selecting an item using <nb-select> (page moves up)
9 participants