Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bundle packages #818

Merged
merged 4 commits into from
Sep 28, 2018
Merged

Fix/bundle packages #818

merged 4 commits into from
Sep 28, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 28, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Add moment and date-fns modules bundling.

@Tibing Tibing requested a review from nnixaa September 28, 2018 10:05
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #818 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   77.04%   77.05%   +0.01%     
==========================================
  Files         201      201              
  Lines        5802     5806       +4     
  Branches      437      439       +2     
==========================================
+ Hits         4470     4474       +4     
  Misses       1237     1237              
  Partials       95       95
Impacted Files Coverage Δ
...c/framework/moment/services/moment-date.service.ts 94.2% <100%> (+0.17%) ⬆️
...amework/date-fns/services/date-fns-date.service.ts 90.9% <100%> (+2.02%) ⬆️

@nnixaa nnixaa merged commit c78ae5f into akveo:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants