Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tibing feature/datepicker #732

Merged
merged 42 commits into from
Sep 20, 2018
Merged

Tibing feature/datepicker #732

merged 42 commits into from
Sep 20, 2018

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Sep 19, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Tibing added 30 commits September 12, 2018 11:44
@Tibing
feat(datepicker): setup
50367cb
@Tibing
Merge branch 'master' into feature/datepicker
5eddecb
@Tibing
fix(calendar): cells emitters
ed161f6
@Tibing
feat(datepicker): add datepicker components
c9f9d26
@Tibing
refactor(datepicker): move transformers in separate file
42eb6e9
@Tibing
refactor(datepicker): move many logic in base picker
ceaf6a9
@Tibing
feat(datepicker): implement form control
ad0c98f
@Tibing
refactor(calendar): add locale service
a564461
@Tibing
refactor(calendar): implement native date service
a073a1d
@Tibing
feat(datepicker): setup validation
5732659
@Tibing
refactor(calendar): fix specs
9cf25e8
@Tibing
refactor(datepicker): fix databindings
eedf8f7
@Tibing
feat(moment): setup moment package
63538ca
@Tibing
feat(date-fns): setup date-fns module
d47bfab
@Tibing
refactor(date-fns): use it only for parsing purpose
2cf9cf2
@Tibing
fix(datepicker): empty parsing exception
56ba443
@Tibing
feat(datepicker): date format input
f30b397
@Tibing
refactor(datepicker): base datepicker component docs
cf9a8e6
@Tibing
refactor(datepicker): rename transformers into adapters
4b0e4b8
@Tibing
feat(datepicker): validate according to inputs
fb2eec1
@Tibing
feat(datepicker): theming
5700984
@Tibing
fix(calendar-kit): native-date.service spec
7f88b9e
@Tibing
feat(date-fns): spec
7ec298f
@Tibing
feat(moment): moment date service spec
dc5b462
@Tibing
Merge branch 'master' into feature/datepicker
0cb5381
@Tibing
refactor(build): bump script
4842f76
@Tibing
feat(build): bump moment and date-fns versions
af08623
@Tibing
feat(datepicker): comments
a7d2aac
@Tibing
feat(datepicker): setup spec
262cc52
@Tibing
feat(datepicker): setup docs
34f8002
@nnixaa nnixaa requested a review from Tibing September 19, 2018 15:23
Tibing
Tibing requested changes Sep 20, 2018
View reviewed changes
Copy link
Member

@Tibing Tibing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add docs about focusing in datepicker

src/framework/theme/components/cdk/overlay/overlay-trigger.ts Outdated
@@ -114,6 +115,64 @@ export class NbHintTriggerStrategy extends NbTriggerStrategy {
hide$: Observable<Event> = observableFromEvent(this.host, 'mouseleave');
}


/**
* Creates open and close events streams, the toggle is empty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toggle event was completely removed from triggers. But comments about toggle trigger still exist. Could you please remove all the mentions of the toggle trigger from this file.

Tibing
Tibing previously approved these changes Sep 20, 2018
View reviewed changes
@Tibing Tibing mentioned this pull request Sep 20, 2018
Closed
2 tasks
@nnixaa nnixaa merged commit c00cc23 into master Sep 20, 2018
@nnixaa nnixaa deleted the Tibing-feature/datepicker branch September 20, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibing Tibing Tibing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnixaa @Tibing