Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): take into account remember me setting #644

Merged
merged 3 commits into from
Aug 16, 2018
Merged

fix(login): take into account remember me setting #644

merged 3 commits into from
Aug 16, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 16, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes: #330.

@yggg yggg requested a review from nnixaa August 16, 2018 12:47
@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #644 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   72.48%   72.44%   -0.04%     
==========================================
  Files         153      153              
  Lines        4270     4272       +2     
  Branches      330      330              
==========================================
  Hits         3095     3095              
- Misses       1111     1113       +2     
  Partials       64       64
Impacted Files Coverage Δ
...h/strategies/password/password-strategy-options.ts 100% <ø> (ø) ⬆️
...work/auth/strategies/password/password-strategy.ts 95.65% <ø> (ø) ⬆️
...framework/auth/components/login/login.component.ts 22.5% <0%> (-1.19%) ⬇️

@nnixaa nnixaa merged commit d35b65b into akveo:master Aug 16, 2018
nnixaa pushed a commit that referenced this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Forms RememberMe boolean is not being used in Login.Component
2 participants