Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/alert #590

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Feat/alert #590

merged 2 commits into from
Jul 30, 2018

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Jul 30, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #590 into master will increase coverage by 0.87%.
The diff coverage is 93.33%.

@@            Coverage Diff            @@
##           master    #590      +/-   ##
=========================================
+ Coverage   68.82%   69.7%   +0.87%     
=========================================
  Files         120     120              
  Lines        3394    3423      +29     
  Branches      241     241              
=========================================
+ Hits         2336    2386      +50     
+ Misses       1014     993      -21     
  Partials       44      44
Impacted Files Coverage Δ
...mework/theme/components/button/button.component.ts 82.81% <66.66%> (-0.8%) ⬇️
...ramework/theme/components/alert/alert.component.ts 94.44% <96.29%> (+28.59%) ⬆️

@nnixaa nnixaa merged commit a7b8ff4 into master Jul 30, 2018
@nnixaa nnixaa deleted the feat/alert branch July 30, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant