feat(theme): add progress-bar component #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
requested changes
May 30, 2018
DEV_DOCS.md
Outdated
|
|
||
| - tests | ||
| ```` | ||
| src/framework/theme/components/your-component/your-component.spec.ts if you want basic rendering |
There was a problem hiding this comment.
if you want basic rendering - > if you want to test basic rendering
DEV_DOCS.md
Outdated
| - register your component in docs | ||
| ```` | ||
| src/playground/your-component/your-component-showcase.component.ts (create example usage of your component) | ||
| src/playground/your-component/your-component-showcase.component.html (most probably looks like <nb-your-component></nb-your-component>) |
DEV_DOCS.md
Outdated
| src/playground/playground.module.ts (register your component in module) | ||
| src/playground/playground-routing.module.ts (routing) | ||
|
|
||
| your-component.component.ts (add line in docs section- * @example(Your component, your-component/your-component-showcase.component) |
There was a problem hiding this comment.
example -> stacked-example
| .progress-container { | ||
| height: nb-theme(progress-bar-height); | ||
| border-radius: nb-theme(progress-bar-radius); | ||
| background-color: nb-theme(progress-bar-bg-color); |
There was a problem hiding this comment.
progress-bar-bg-color -> rogress-bar-bg
| background-color: nb-theme(progress-bar-primary-bg-color); | ||
| } | ||
| &.info { | ||
| background-color: nb-theme(progress-bar-info-bg-color); |
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| */ | ||
|
|
||
| import {Component, Input} from '@angular/core'; |
| * Progress bar accepts property `value` in range 0-100 | ||
| * @stacked-example(Progress bar, progress-bar/progress-bar-showcase.component) | ||
| * | ||
| * Progress bar background configured by providing a `status` property: |
There was a problem hiding this comment.
..could be configured by..
| * Progress bar background configured by providing a `status` property: | ||
| * @stacked-example(Progress bar status, progress-bar/progress-bar-status.component) | ||
| * | ||
| * Progress bar size (height and font-size) configured by providing a `size` property: |
There was a problem hiding this comment.
..could be configured by..
| * Progress bar size (height and font-size) configured by providing a `size` property: | ||
| * @stacked-example(Progress bar size, progress-bar/progress-bar-size.component) | ||
| * | ||
| * `displayValue` property shows current value inside progress bar. It's also possible to add custom text inside tag: |
| @Component({ | ||
| selector: 'nb-progress-bar', | ||
| template: ` | ||
| <div class="progress-container {{size ? '' + size : ''}}"> |
… inline examples (akveo#427)
SashaSkywalker
force-pushed
the
feat/progress-bar
branch
from
ec8770b to
4c5f2a5
Compare
nnixaa
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Progress bar component