Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixins may not be defined within control directives or other mixins #339

Closed
1 of 2 tasks
ghost opened this issue Apr 1, 2018 · 7 comments
Closed
1 of 2 tasks

Mixins may not be defined within control directives or other mixins #339

ghost opened this issue Apr 1, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Apr 1, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:

Crashes when compiling, with the message:

ERROR in ./node_modules/raw-loader!./node_modules/postcss-loader/lib??embedded!./node_modules/sass-loader/lib/loader.js??ref--8-3!./src/app/@theme/styles/styles.scss
Module build failed: 
  @mixin hover-checked-border($color) {
        ^
      Mixins may not be defined within control directives or other mixins.
      in /Users/.../node_modules/@nebular/theme/styles/global/bootstrap/_custom-forms.scss (line 8, column 10)

Expected behavior:

the app should compile

Steps to reproduce:

Not sure here, it happened after messing with the packages organization. I am posting here because it seems like a valid bug, as sass shouldn't allow nested mixins (I'm not an expert, I just read this)

Other information:

Angular, Nebular

Angular 5.2.9
Nebular 2.0.0-rc.6

Please delete this issue if the nested mixin code is valid indeed.

@helxsz
Copy link

helxsz commented Apr 2, 2018

Having the same problem here.

Angular 5.2.6
Nebular 2.0.0-rc.6

@nnixaa
Copy link
Collaborator

nnixaa commented Apr 2, 2018

Hey Guys, thanks for reporting. It's been fixed already and will be released this week. Here's a workaround for the time being #316 (comment).

@andreidiaconescu
Copy link

andreidiaconescu commented Apr 5, 2018

Hello,
Can you please release the fix if possible, we would greatly need it.
The temporary proposed fix works with npm, but not with yarn (we need to use yarn, for having aliases in packages.json).
Thank you !

@jaysturm
Copy link

jaysturm commented Apr 5, 2018

Wondering about the status of this fix? The workaround doesn't fix everything for me. after building with [email protected] I get the following =>

ERROR in ./node_modules/raw-loader!./node_modules/postcss-loader/lib??embedded!./node_modules/sass-loader/lib/loader.js??ref--8-3!./src/app/@theme/styles/styles.scss
Module build failed:
undefined
^
Argument $color of lighten($color, $amount) must be a color

Backtrace:
node_modules/@nebular/theme/components/checkbox/_checkbox.component.theme.scss:13, in function lighten

@nnixaa
Copy link
Collaborator

nnixaa commented Apr 5, 2018

Hi @jaysturm, please stop posting comments into every closed issue you found related as you are creating a lot of notification's noise for a lot of people. Please consider creating a new one with a description of your setup and reproducible examples. Thanks.

@jaysturm
Copy link

jaysturm commented Apr 5, 2018

@nnixaa no problem, I have removed my other comments. So you would like me to create a new issue on something that you are considering fixed? I was simply wondering when your fixes were planned to be released. I will open a new issue, thanks.

@Suyashjc
Copy link

npm i [email protected] this should solve the problem make sure your node version is below 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants