Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scene is not visible full screen #3226

Closed
ggunti opened this issue Aug 28, 2018 · 5 comments
Closed

New scene is not visible full screen #3226

ggunti opened this issue Aug 28, 2018 · 5 comments
Labels
needs response from author needs steps to reproduce Needing information about how to reproduce

Comments

@ggunti
Copy link

ggunti commented Aug 28, 2018

Version

  • react-native-router-flux v4.0.1
  • react-native v0.55.4

Expected behaviour

Open the required scene full screen of course.

Actual behaviour

The required scene is opened, but on the bottom is still visible a little portion from the previous screen (the camera).
See the video: https://vimeo.com/287135365
I called Actions.sketch(), but on the background is still alive the previous scene. On the bottom of the screen is visible a little portion of it. Why?

Steps to reproduce

  1. Use a react-native-camera-kit camera component as initial scene
  2. After taking a photo, call Actions.nextScene()

I call this function when taking a picture:
untitled

@daviscabral
Copy link
Collaborator

Can you provide the route and component structure used? The way you explained here - it is really hard to reproduce from my side to try to help you.

I noticed that with the last release, a lot of issues might be happening due the wrong version match between a lot of dependencies.

Could you check if your version is compatible?

react-native react
0.46.x 16.0.0-alpha.12
0.47.x 16.0.0-alpha.12
0.48.x 16.0.0-alpha.12
0.49.x 16.0.0-beta.5
0.50.x 16.0.0
0.51.x 16.0.0
0.52.x 16.2.0
0.54.x 16.3.0-alpha.1
0.55.x 16.3.1
0.56.x 16.4.1

Also, check the breaking changes related to the version you are using and the most recent - that might shed a light here:
https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md

@daviscabral daviscabral added needs response from author needs steps to reproduce Needing information about how to reproduce labels Sep 2, 2018
@ggunti
Copy link
Author

ggunti commented Sep 3, 2018

"react": "16.3.1",
"react-native": "0.55.4",
"react-native-router-flux": "^4.0.1",

The routes class which I use:
routes

The component:
camera
this.props.takePicture is actually the function which I attached on my previous comment, where I call Actions.sketch().

It is strange that the new scene (sketch - in my case) keep showing a little portion of the previous/initial scene (the camera).

@daviscabral
Copy link
Collaborator

@ggunti Cool. Thanks. I can't see anything wrong there - have you inspected the views to see from where is that coming? Also, could you try to use yarn add aksonov/react-native-router-flux to test if the new version of RN that was merged and the other fixes to reset and push/pop might fix that?

@ggunti
Copy link
Author

ggunti commented Sep 4, 2018

The problem is
<CameraKitCamera style={styles.preview} ref={this.props.cameraRef} />
If I remove CameraKitCamera, then the problem disappear, but I do not want to remove it and I don't know why CameraKitCamera causes this problem.
styles.preview is actually this: { flex: 1, justifyContent: 'flex-end', alignItems: 'center' }

Tried to use Actions.sketch({ type: 'reset' }), but the problem do not disappear.
I also noticed that if I lock the screen and after unlock it, then the problem disappear, but obviously this is not a solution.

@daviscabral Can you reproduce the bug?

@aksonov
Copy link
Owner

aksonov commented Sep 5, 2018

If you don't have problem without camera then it is not problem of RNRF. Maybe react-navigation and CameraKitCamera is not compatible somehow. Please try pure react-navigation first.

@aksonov aksonov closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response from author needs steps to reproduce Needing information about how to reproduce
Projects
None yet
Development

No branches or pull requests

3 participants