after update to Release 4.0.2 props not working... #3206

lordenas · 2018-08-23T08:59:06Z

Version

Tell us which versions you are using:

react-native-router-flux v 4.0.2 (v3 is not supported)
react-native ~0.55.2

Expected behaviour

login .js
Actions.Account_list({ data: 'test!' })

accontlist.js
console.log(this.props.data) = undefined

Actual behaviour

console.log(this.props.data) = test!

daviscabral · 2018-08-23T09:22:08Z

Please provide the code from the Example folder that reproduces this error.

lordenas · 2018-08-23T09:27:05Z

In the loginForm.js function myoutput() after a response is received, makes the transition to Action.Account_list({token: this.state.token, userName:this.state.userName})

But Account_list.js stopped seeing these props

lordenas · 2018-08-23T11:40:51Z

Something went wrong... I went back to yesterday's version and everything worked. Somehow ceased to be transferred to the props... If you go back to version 4.0.0-beta.31, everything works fine...

dextermb · 2018-08-23T12:50:26Z

I am also noticing that my props are not being populated

<TouchableOpacity
	style={_Challenges.container}
	onPress={() => Actions['ChallengeDetails'](
		{
			...props,
			challenge: challenges[i]
		}
	)}
>
    // ...
</TouchableOpacity>

Output from this.props within componentDidMount:

Object {
  "animationEnabled": false,
  "drawerImage": 2,
  "drawerPosition": "right",
  "headerMode": "none",
  "init": true,
  "name": "_ChallengeDetails",
  "navigation": Object {
    "actions": Object {
      "closeDrawer": [Function closeDrawer],
      "dismiss": [Function dismiss],
      "goBack": [Function goBack],
      "navigate": [Function navigate],
      "openDrawer": [Function openDrawer],
      "pop": [Function pop],
      "popToTop": [Function popToTop],
      "push": [Function push],
      "replace": [Function replace],
      "reset": [Function reset],
      "setParams": [Function setParams],
      "toggleDrawer": [Function toggleDrawer],
    },
    "addListener": [Function addListener],
    "closeDrawer": [Function anonymous],
    "dangerouslyGetParent": [Function anonymous],
    "dismiss": [Function anonymous],
    "dispatch": [Function anonymous],
    "getChildNavigation": [Function getChildNavigation],
    "getParam": [Function anonymous],
    "getScreenProps": [Function anonymous],
    "goBack": [Function anonymous],
    "isFocused": [Function isFocused],
    "navigate": [Function anonymous],
    "openDrawer": [Function anonymous],
    "pop": [Function anonymous],
    "popToTop": [Function anonymous],
    "push": [Function anonymous],
    "replace": [Function anonymous],
    "reset": [Function anonymous],
    "router": undefined,
    "setParams": [Function anonymous],
    "state": Object {
      "key": "id-1535028451888-41",
      "params": Object {
        "animationEnabled": false,
        "drawerImage": 2,
        "drawerPosition": "right",
        "headerMode": "none",
        "init": true,
        "panHandlers": null,
      },
      "routeName": "_ChallengeDetails",
    },
    "toggleDrawer": [Function anonymous],
  },
  "panHandlers": null,
  "screenProps": undefined,
}

I do not see challenge prop 😨

dextermb · 2018-08-23T12:55:45Z

@daviscabral Any ideas where I can find the code that might be causing this within the source?

daviscabral · 2018-08-23T18:36:50Z

I noticed that with [email protected] - Scenes are being rendered all together with the Stack. So, when you are really logging it - it has no params being passed to it yet, so probably, the lifecycle is wrong, and that might be probably the issue with all the recent opened tickets here. If someone here have time to help dig on that, I would appreciate.

This might be related to #3202, #3197, #3196, and a couple of others?

dextermb · 2018-08-24T06:42:13Z

@daviscabral is this an issue with this library or react navigation? Maybe it's worth creating an issue in react-navigation if it is something to do with them. I'm need an app pushing out sometime today, but obviously I can't do that if navigation isn't working properly.

daviscabral · 2018-08-24T06:47:57Z

I need to investigate to be sure. Right now I am running late with work and might get back to it in the weekend.

What I usually do in these cases, where I have a deadline, is to fork the project I need, do my changes and install it direct from there with yarn, pointing the github repo.

dextermb · 2018-08-24T06:51:26Z

@daviscabral hmm alright. My issue is that I need onStateChange which is in the latest releases. When does onStateChange get implemented into react-nativation? Maybe we could do a branch from flux's beta 27 and just introduce onStateChange into it until these issues are resolved?

daviscabral · 2018-08-24T11:44:02Z

I think you can fork the repo, make the changes and then use that fork. I don't think beta versions will be supported. At least I have no plans to work with that (it will cause one more version to give maintenance).

daviscabral · 2018-08-25T17:19:44Z

As I've already commented in other issues and ended opening a specific issue for that (#3213) - beta.31 was the last one using [email protected].

After that RNRF had a major upgrade in the dependency to version 2.0 - what changed a lot of things (and might be the reason why so many stuff are not working as before).

I am still trying to catch up on issues and bugs here.

tuxity · 2018-08-27T15:07:00Z

There is an ugly fix we can use until it's fixed ?

EDIT: I switched back to 4.0.0-beta.31 and it's working again

dextermb · 2018-08-28T06:26:38Z

@tuxity Unfortunately I'm using the onStateChange on Router and in 4.0.0-beta.31 it doesn't have it yet. Any updates on a potential fix, @daviscabral?

daviscabral · 2018-08-28T06:28:49Z

Not yet - I'll try to hack something on that 👍

dextermb · 2018-08-30T08:06:41Z

@daviscabral master seems to have props working again. Perhaps the version bump for react-navigation resolved the issue?

dextermb · 2018-08-30T14:44:30Z

@daviscabral Nevermind. This isn't resolved.

<TouchableOpacity
	style={_Challenges.container}
	onPress={() => Actions['ChallengeDetails'](
		{
			...props,
			challenge: challenges[i]
		}
	)}
>
    // ...
</TouchableOpacity>

👎

daviscabral · 2018-08-30T18:04:53Z

I switched back to 4.0.0-beta.31 and it's working again

That's because [email protected] is used there - in the recent versions RNEF is using react-navigation@2 that has some breaking changes.

aksonov · 2018-09-05T10:52:56Z

@lordenas As @daviscabral mentioned we need you to reproduce the issue based on Example project, not your project.

dextermb · 2018-09-05T10:57:02Z

@aksonov We've confirmed that it's an bug with how React Native Router Flux communicates with the latest React Navigation versions

aksonov · 2018-09-05T11:00:10Z

@dextermb Sorry, but I can't help you until you don't give me modified Example. So far I can't find the bug with passing props.

lordenas · 2018-09-05T11:06:18Z

@aksonov, as I said, there is a problem in passing parameters.
loginpage.js
Action.Account_list({test: 'test'})

Account_list.js
console.log(this.props.test) = undefined

All this occurred after upgrading to version 4.0.2 (4.01 same problem). The props just are not transferred to the other component.

dextermb · 2018-09-05T11:35:35Z

@aksonov Do you have a snack example making it easier for us to show examples?

aksonov · 2018-09-05T11:36:31Z

No. PR is welcome to make Example project as Expo project.

dextermb · 2018-09-05T12:02:23Z

@aksonov Seem like your app.json in the example doesn't even work with Expo without making changes to it.

Error: Missing app.json. See https://docs.expo.io/

From what I've noticed it's because you're missing required attributes.

aksonov · 2018-09-05T12:03:45Z

Please re-read my sentence above again.
NO, we don't have Expo-compartible Example now. You are WELCOME to add PR and modify Example to make Expo-compartible

dextermb · 2018-09-05T12:14:24Z

@aksonov Is there any documentation on how to run it without Expo? I'd rather try and get functionality working properly before converting the example to Expo

daviscabral · 2018-09-06T16:38:34Z

I found out a few things about the tabBar and props - but are mostly the way things works now with React Navigation.

dextermb · 2018-09-07T06:28:01Z

@daviscabral Cool, I'll give it a go and let you know 💃

daviscabral · 2018-09-07T06:30:39Z

Do it please - just need that confirmed to proceed with the release.

dextermb · 2018-09-07T06:39:19Z

@daviscabral I'll continue the discussion in the PR thread

aksonov · 2018-09-24T15:59:11Z

Please check 4.0.3 release and create new ticket if any.

jqtruong · 2019-06-11T16:39:56Z

4.0.6 not working either; any luck, @daviscabral @dextermb ?

anuj002 · 2019-07-11T13:15:55Z

Yes! I found the problem in 'Tab'.
Tabs are 'wrapped' by default - i.e. all children are wrapped by Stack with own nav bar. You may disable wrapping by using wrap={false} for Tabs and check passing props again.

<Scene key="Scene" tabs={true} wrap={false}> <Scene key="someTab" component={SomeTab} title="SomeTab" icon={TabIcon}/> <Scene key="Modal" component={Modal} title="Modal" hideNavBar direction="vertical"/> </Scene>

Here props are find when passing from someTab to Modal via Actions.Modal({someProp: theProp})

Znow · 2019-10-01T07:17:50Z

Latest version not working either - also tried with wraps={false}without luck.

In my case, im using the element with a custom tab bar component:

<Tabs
          key={Routes.EDIT_NOTIFICATION}
          tabBarComponent={CustomTabBar}
          tabBarPosition="top"
          titleStyle={styles.titleText}
          navigationBarStyle={{backgroundColor: '#4099DA', height: 80, paddingTop: 10}}
          back={true}
          backButtonTintColor="white"
          backTitle="Back"
          backButtonTextStyle={{color: '#fff'}}
          renderRightButton={Profile}
          swipeEnabled={false}
          wrap={false}
        >
          <Scene 
            key={Routes.EDIT_NOTIFICATION_DETAILS}
            component={NotificationDetailsScreen} 
            hideNavBar/>
          <Scene 
            key={Routes.EDIT_NOTIFICATION_IMAGES}
            component={ImagesScreen} 
            hideNavBar/>
          <Scene 
            key={Routes.EDIT_NOTIFICATION_DAMAGE_CAUSE}
            component={DamageCauseScreen} 
            hideNavBar/>
        </Tabs>

And I can actually see my passed value in the custom tab component, but not in the scene I am showing

daviscabral added the needs response from author label Aug 23, 2018

daviscabral added bug and removed needs response from author labels Aug 24, 2018

daviscabral self-assigned this Sep 3, 2018

daviscabral added backwards-incompatible Breaking changes and removed backwards-incompatible Breaking changes labels Sep 3, 2018

daviscabral mentioned this issue Sep 3, 2018

Refresh not working as expected in several cases #3240

Merged

dextermb mentioned this issue Sep 3, 2018

How can i get the props after Actions.popTo in the previous scene? #3241

Closed

daviscabral mentioned this issue Sep 3, 2018

Can't pass props to scene from Action.key(props). Think this way should work too. #3236

Closed

aksonov closed this as completed Sep 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

after update to Release 4.0.2 props not working... #3206

after update to Release 4.0.2 props not working... #3206

lordenas commented Aug 23, 2018

daviscabral commented Aug 23, 2018

lordenas commented Aug 23, 2018 •

edited

Loading

lordenas commented Aug 23, 2018 •

edited

Loading

dextermb commented Aug 23, 2018

dextermb commented Aug 23, 2018

daviscabral commented Aug 23, 2018

dextermb commented Aug 24, 2018

daviscabral commented Aug 24, 2018

dextermb commented Aug 24, 2018

daviscabral commented Aug 24, 2018

daviscabral commented Aug 25, 2018

tuxity commented Aug 27, 2018 •

edited

Loading

dextermb commented Aug 28, 2018

daviscabral commented Aug 28, 2018

dextermb commented Aug 30, 2018

dextermb commented Aug 30, 2018

daviscabral commented Aug 30, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

lordenas commented Sep 5, 2018 •

edited

Loading

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

daviscabral commented Sep 6, 2018

dextermb commented Sep 7, 2018

daviscabral commented Sep 7, 2018

dextermb commented Sep 7, 2018

aksonov commented Sep 24, 2018

jqtruong commented Jun 11, 2019

anuj002 commented Jul 11, 2019

Znow commented Oct 1, 2019 •

edited

Loading

after update to Release 4.0.2 props not working... #3206

after update to Release 4.0.2 props not working... #3206

Comments

lordenas commented Aug 23, 2018

Version

Expected behaviour

Actual behaviour

daviscabral commented Aug 23, 2018

lordenas commented Aug 23, 2018 • edited Loading

lordenas commented Aug 23, 2018 • edited Loading

dextermb commented Aug 23, 2018

dextermb commented Aug 23, 2018

daviscabral commented Aug 23, 2018

dextermb commented Aug 24, 2018

daviscabral commented Aug 24, 2018

dextermb commented Aug 24, 2018

daviscabral commented Aug 24, 2018

daviscabral commented Aug 25, 2018

tuxity commented Aug 27, 2018 • edited Loading

dextermb commented Aug 28, 2018

daviscabral commented Aug 28, 2018

dextermb commented Aug 30, 2018

dextermb commented Aug 30, 2018

daviscabral commented Aug 30, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

lordenas commented Sep 5, 2018 • edited Loading

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

aksonov commented Sep 5, 2018

dextermb commented Sep 5, 2018

daviscabral commented Sep 6, 2018

dextermb commented Sep 7, 2018

daviscabral commented Sep 7, 2018

dextermb commented Sep 7, 2018

aksonov commented Sep 24, 2018

jqtruong commented Jun 11, 2019

anuj002 commented Jul 11, 2019

Znow commented Oct 1, 2019 • edited Loading

lordenas commented Aug 23, 2018 •

edited

Loading

lordenas commented Aug 23, 2018 •

edited

Loading

tuxity commented Aug 27, 2018 •

edited

Loading

lordenas commented Sep 5, 2018 •

edited

Loading

Znow commented Oct 1, 2019 •

edited

Loading