Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for multiple Router.uriPrefix and Scene.path values #3040

Closed
grahamyesfit opened this issue May 17, 2018 · 1 comment
Closed

Request for multiple Router.uriPrefix and Scene.path values #3040

grahamyesfit opened this issue May 17, 2018 · 1 comment

Comments

@grahamyesfit
Copy link

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.0-beta.27
  • react-native v0.55.4

We are using an attribute provider (AppsFlyer) so deep links will either be to https://yes.fit/path/... or https://yesfit.onelink.me/other-path/.... For the 2nd URL, we don't have control over the first path value (in this example, it's other-path).

Consequently, I've set the Router uriPrefix property to yesfit.onelink.me in order to process deep links to that location. Unfortunately, this means that regular non-AppsFlyer links will no longer work, as the uriPrefix would have to be yes.fit in order for it to work. It would really help me out if uriPrefix was an array of strings so that I can pass both domains.

In addition, because we have no control over the path portion of the URL from AppsFlyer, it would help me out if the Scene.path property could also take an array of strings.

So, my Router definition would look something like this:

<Router uriPrefix={['yes.fit', 'yesfit.onelink.me']}>
  <Scene path={['/path', '/other-path']} ... />
</Router>

With this configuration, deep linking will work for both https://yes.fit/path/... and https://yesfit.onelink.me/other-path/...

@aksonov
Copy link
Owner

aksonov commented Aug 8, 2018

It is not supported, PR is really welcome.

@aksonov aksonov closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants