Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive slowdown after beta 14 #2270

Closed
alexchia opened this issue Aug 20, 2017 · 1 comment
Closed

Massive slowdown after beta 14 #2270

alexchia opened this issue Aug 20, 2017 · 1 comment

Comments

@alexchia
Copy link

alexchia commented Aug 20, 2017

Version

  • react-native-router-flux v4.0.0-beta.18
  • react-native 0.47.1
  • react 16.0.0-alpha.12

This is a general enquiry - what were the changes between beta 14 and beta 15 in RNRF?

My app experiences a massive slowdown whenever I change tabs or push a new screen into the stackcontroller. It takes almost 1-3 seconds to change, even in release mode.

This completely disappears when I revert back to beta 14 but happens in beta 15.

I strangely don't experience this in the Example project so maybe it's because of other dependencies? or the RN/React version?

My simple router is organized as follows:

<Router>
        <Tabs>
           <Stack key="tab1">
                ...Some <Scenes>
           </Stack>
           <Stack key="tab2">
               ...Some <Scenes>
           </Stack>

        </Tabs>
</Router>

For the example below, all the scenes I use are identical.

Switching from tab1 to tab2, it's quick if there's only 1 scene under tab1 and 1 scene under tab2.

When I have 3 simple scenes under tab1 and 1 simple scene under tab2, there is a huge lag when i switch from tab1 to tab2.

However, when I have 1 simple scenes under tab1 and 3 simple scenes under tab2, it is quick again.

Any help listing the changes between beta 14 and beta 15 will be much appreciated and I will be happy to report my findings for a patch.

@alexchia
Copy link
Author

Found that the issue happens when I use different TabIcon classes for each tab.
Solved when I have all the tabs use the same TabIcon class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant