Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideNavBar issue on tabs scene #2268

Closed
todorone opened this issue Aug 20, 2017 · 4 comments
Closed

hideNavBar issue on tabs scene #2268

todorone opened this issue Aug 20, 2017 · 4 comments
Labels

Comments

@todorone
Copy link
Contributor

todorone commented Aug 20, 2017

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.0-beta18 (v3 is not supported)
  • react-native v0.46.1

Expected behaviour

hideNavBar prop should hide navigation bar for Scene with tabs prop enabled.

Actual behaviour

hideNavBar prop does not hide navigation bar for Scene with tabs prop enabled, there is blank NavBar at the top. To get rid of NavBar I have to add navBar={() => <View />}.

@EskelCz
Copy link

EskelCz commented Aug 20, 2017

Can confirm, I have the exact same problem.

@aksonov aksonov added the bug label Aug 21, 2017
@aksonov
Copy link
Owner

aksonov commented Aug 21, 2017

@todorone As workaround could you use hideNavBar for all tab children?

@todorone
Copy link
Contributor Author

@aksonov I've tried to add hideNavBar to all tab children, but it didn't work. Anyway, I'll use workaround with invisible component as navBar prop until bug is fixed. Thanks a lot for Your efforts with rnrf.

@aksonov
Copy link
Owner

aksonov commented Aug 22, 2017

I've just added hideNavBar to all tabs for Example project and it works well. Could you reproduce the issue with Example project?

For general fix - sorry, I can't fix this 'bug' because hideNavBar is NOT 'inheritable' property (i.e. children should not inherit it from parent).

@aksonov aksonov closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants