Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't have react-native-router-flux in package.json #1

Open
Janiczek opened this issue Jun 13, 2016 · 2 comments
Open

Doesn't have react-native-router-flux in package.json #1

Janiczek opened this issue Jun 13, 2016 · 2 comments

Comments

@Janiczek
Copy link

Causes an issue when trying to run with just react-native-mobx and not react-native-router-flux in package.json. This package depends on RNRF, so it should probably have it as a dependency.
@aksonov
Copy link
Owner

aksonov commented Jul 20, 2016

Thanks, will add it.

@benjick
Copy link

benjick commented Aug 18, 2016

Wouldn't it be better to have them as peerDependency to let the user handle their own versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Janiczek @benjick @aksonov