From 22c0edf575c1db1c6896bcf23d2a80b7d1545c10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Wed, 1 Jul 2020 12:54:22 +0200 Subject: [PATCH] Mono: reenable tests in System.ComponentModel.Composition.Registration that were fixed Closes https://github.com/dotnet/runtime/issues/32744 --- .../Composition/Registration/ExportBuilderUnitTests.cs | 4 ---- .../Composition/Registration/PartBuilderInterfaceTests.cs | 2 -- .../Composition/Registration/PartBuilderTests.cs | 1 - .../Composition/Registration/PartBuilderUnitTests.cs | 6 ------ .../Registration/RegistrationBuilderExportFuncTests.cs | 1 - .../Composition/Registration/RegistrationBuilderTests.cs | 2 +- 6 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs index 13ac342236c48..5140700eda991 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/ExportBuilderUnitTests.cs @@ -68,7 +68,6 @@ public FooImporter4(IFoo fooImporter) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ExportInterfaceWithTypeOf1() { var ctx = new RegistrationBuilder(); @@ -84,7 +83,6 @@ public void ExportInterfaceWithTypeOf1() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ExportInterfaceWithTypeOf2() { var ctx = new RegistrationBuilder(); @@ -100,7 +98,6 @@ public void ExportInterfaceWithTypeOf2() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ExportInheritedInterfaceWithImplements1() { var ctx = new RegistrationBuilder(); @@ -116,7 +113,6 @@ public void ExportInheritedInterfaceWithImplements1() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ExportInheritedInterfaceWithImplements2() { var ctx = new RegistrationBuilder(); diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs index e7187d4c33185..8be2edfc03bc8 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderInterfaceTests.cs @@ -48,7 +48,6 @@ public class Importer } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void StandardExportInterfacesShouldWork() { var builder = new RegistrationBuilder(); @@ -83,7 +82,6 @@ public void StandardExportInterfacesShouldWork() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void StandardExportInterfacesDefaultContractShouldWork() { //Same test as above only using default export builder var builder = new RegistrationBuilder(); diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs index 478db2824a1f0..23c112c60cbf0 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderTests.cs @@ -416,7 +416,6 @@ public void ExportSelectorNull_ShouldThrowArgumentNull() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void InsideTheLambdaCallGetCustomAttributesShouldSucceed() { //Same test as above only using default export builder diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs index 2d71be3ed57e2..2b89d8a9061b4 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/PartBuilderUnitTests.cs @@ -126,7 +126,6 @@ public ManyConstructorsController( public class PartBuilderUnitTests { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ManyConstructorsControllerFindLongestConstructor_ShouldSucceed() { var ctx = new RegistrationBuilder(); @@ -155,7 +154,6 @@ public void ManyConstructorsControllerFindLongestConstructor_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void ManyConstructorsControllerFindLongestConstructorAndImportByName_ShouldSucceed() { var ctx = new RegistrationBuilder(); @@ -193,7 +191,6 @@ public void ManyConstructorsControllerFindLongestConstructorAndImportByName_Shou } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void LongestConstructorWithAttribute_ShouldSucceed() { var ctx = new RegistrationBuilder(); @@ -213,7 +210,6 @@ public void LongestConstructorWithAttribute_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void LongestConstructorShortestWithAttribute_ShouldSucceed() { var ctx = new RegistrationBuilder(); @@ -233,7 +229,6 @@ public void LongestConstructorShortestWithAttribute_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void AmbiguousConstructorWithAttributeAppliedToOne_ShouldSucceed() { var ctx = new RegistrationBuilder(); @@ -255,7 +250,6 @@ public void AmbiguousConstructorWithAttributeAppliedToOne_ShouldSucceed() [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void AmbiguousConstructor_ShouldFail() { var ctx = new RegistrationBuilder(); diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs index 18c800f16b02f..fdc84d0a461c1 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderExportFuncTests.cs @@ -22,7 +22,6 @@ public class Factory } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] public void RegistrationBuilder_WithExportDelegatesShouldNotThrow() { var rb = new RegistrationBuilder(); diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs index 924a3d44d0f37..ecdc4b8df1815 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System/ComponentModel/Composition/Registration/RegistrationBuilderTests.cs @@ -46,7 +46,7 @@ public DiscoveredCatalog() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32744", TestRuntimes.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32743", TestRuntimes.Mono)] public void ShouldSucceed() { var rb = new RegistrationBuilder();