Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support obtaining protobuf schemas from schema registry for grpc services #697

Closed
1 of 3 tasks
jfallows opened this issue Jan 4, 2024 · 2 comments · Fixed by #757
Closed
1 of 3 tasks

Support obtaining protobuf schemas from schema registry for grpc services #697

jfallows opened this issue Jan 4, 2024 · 2 comments · Fixed by #757
Assignees
Labels
story Feature description from user's perspective

Comments

@jfallows
Copy link
Contributor

jfallows commented Jan 4, 2024

Describe the desired outcome from the user's perspective
As a developer, I want to deploy updated protobuf schemas for grpc services and protobuf message validation without having to restart Zilla.

Acceptance criteria

  • grpc binding can retrieve protobuf schemas from schema registry
  • updated protobuf schema retrieved when schema registry cache max-age elapses

Additional context
None

Tasks

  • Integrate catalog with grpc binding to obtain protobuf schemas
  • Update grpc binding reference docs
  • Update grpc binding configurations in zilla-examples
@jfallows jfallows added the story Feature description from user's perspective label Jan 4, 2024
@dudo
Copy link

dudo commented Jan 9, 2024

Would this add the magic byte to the message?

@jfallows
Copy link
Contributor Author

jfallows commented Jan 17, 2024

Would this add the magic byte to the message?

@dudo The grpc binding currently produces raw protobuf messages towards the grpc-kafka binding, and will continue to maintain compatibility even when fetching the protobuf schema from schema-registry catalog in zilla.yaml.

However, specifying the type of messages on the topic in kafka cache_client binding using schema-registry catalog will prefix the magic byte, the schema id and message indexes onto the kafka topic, allowing a Kafka client with protobuf serdes and schema registry to fully deserialize the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Feature description from user's perspective
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants