Akka.Cluster: harden ignored gossip messages #7278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added our unique address just in case the issue here is gossip intended for previous incarnations of ourselves following a fast restart.
Aaronontheweb
commented
Jul 10, 2024
| _cluster.LogInfo("Ignoring received gossip intended for someone else, from [{0}] to [{1}]. Our full address is [{2}]", | ||
| from.Address, envelope.To, SelfUniqueAddress); | ||
|
|
||
| // TODO: if the gossip is received for a version of ourselves with a different UID, do we issue a Down command? |
There was a problem hiding this comment.
Valid question - what we need to do here will be determined by what we see in the enhanced log messages, but I suspect in our cluster testing we're seeing some gossip for old incarnations of current nodes. Need to log the UID to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added our unique address just in case the issue here is gossip intended for previous incarnations of ourselves following a fast restart. This is just for improving diagnostic clarity.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):